Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Upgrade to flatc version 23.5.26 #38990

Closed
danepitkin opened this issue Nov 29, 2023 · 1 comment · Fixed by #38991
Closed

[Java] Upgrade to flatc version 23.5.26 #38990

danepitkin opened this issue Nov 29, 2023 · 1 comment · Fixed by #38991
Assignees
@danepitkin
Labels
Breaking Change Includes a breaking change to the API Component: Java Type: enhancement
Milestone
15.0.0

Comments

@danepitkin
Copy link
Member

Describe the enhancement requested

flatc v23.5.26 is the same version now used in C++. See #38650 (comment)

Component(s)

Java
@github-actions github-actions bot mentioned this issue Nov 29, 2023
Merged
@lidavidm lidavidm added the Breaking Change Includes a breaking change to the API label Nov 30, 2023
@lidavidm
Copy link
Member

Tagging as breaking change since an upstream Flatbuffers change means that a method that was previously generated in Feature.java is no longer present. (It's doubtful anyone actually uses it, but just in case.)

@lidavidm lidavidm added this to the 15.0.0 milestone Nov 30, 2023
lidavidm pushed a commit that referenced this issue Nov 30, 2023
@danepitkin
GH-38990: [Java] Upgrade to flatc version 23.5.26 (#38991)
d555890 
### Rationale for this change

Upgrade flatc version to match the C++ implementation.

### What changes are included in this PR?

* flatc upgraded to v23.5.26 and flatbuffer files regenerated

### Are these changes tested?

Tested via CI/unit tests

### Are there any user-facing changes?

Yes, but it's highly unlikely any user will use the flatbuffers directly.
* Closes: #38990

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@danepitkin @dgreiss
apacheGH-38990: [Java] Upgrade to flatc version 23.5.26 (apache#38991)
f266e7d 
### Rationale for this change

Upgrade flatc version to match the C++ implementation.

### What changes are included in this PR?

* flatc upgraded to v23.5.26 and flatbuffer files regenerated

### Are these changes tested?

Tested via CI/unit tests

### Are there any user-facing changes?

Yes, but it's highly unlikely any user will use the flatbuffers directly.
* Closes: apache#38990

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danepitkin danepitkin

Labels
Breaking Change Includes a breaking change to the API Component: Java Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38990: [Java] Upgrade to flatc version 23.5.26 danepitkin/arrow
2 participants
@lidavidm @danepitkin