Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Fix ArrayData staticcheck nil check #39116

Closed
zeroshade opened this issue Dec 6, 2023 · 0 comments · Fixed by #39117
Closed

[Go] Fix ArrayData staticcheck nil check #39116

zeroshade opened this issue Dec 6, 2023 · 0 comments · Fixed by #39117
Assignees
@zeroshade
Labels
Component: Go Type: bug
Milestone
15.0.0

Comments

@zeroshade
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

Go CI's are currently throwing a staticcheck issue with the following error text:

arrow/array/data.go:209:29: this comparison is always true (SA4023)
	arrow/array/data.go:209:13: the lhs of the comparison is the 1st return value of this function call
	arrow/array/data.go:179:16: (*github.com/apache/arrow/go/v15/arrow/array.Data).Dictionary never returns a nil interface value

Looking at the code it should just use d.dictionary directly rather than calling d.Dictionary()

Component(s)

Go
zeroshade added a commit to zeroshade/arrow that referenced this issue Dec 6, 2023
@zeroshade
apacheGH-39116: [Go] Fix CI Staticcheck
f00e214
@github-actions github-actions bot mentioned this issue Dec 6, 2023
Merged
@kou kou closed this as completed in #39117 Dec 7, 2023
kou pushed a commit that referenced this issue Dec 7, 2023
@zeroshade
GH-39116: [Go] Fix CI Staticcheck (#39117)
fe83387 
### Rationale for this change
Fixing CI Staticcheck nil check. Pretty straightforward

* Closes: #39116

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Dec 7, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@zeroshade @dgreiss
apacheGH-39116: [Go] Fix CI Staticcheck (apache#39117)
531bde5 
### Rationale for this change
Fixing CI Staticcheck nil check. Pretty straightforward

* Closes: apache#39116

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Go Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39116: [Go] Fix CI Staticcheck zeroshade/arrow
2 participants
@kou @zeroshade