Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] -DARROW_HDFS may add needless system Protobuf dependency for static linking #39136

Closed
kou opened this issue Dec 8, 2023 · 0 comments · Fixed by #39137
Closed

[C++] -DARROW_HDFS may add needless system Protobuf dependency for static linking #39136

kou opened this issue Dec 8, 2023 · 0 comments · Fixed by #39137
Assignees
@kou
Labels
Component: C++ Type: bug
Milestone
15.0.0

Comments

@kou
Copy link
Member

kou commented Dec 8, 2023

Describe the bug, including details regarding any error messages, version, and platform.

See https://github.com/apache/arrow/pull/13911/files#r1418811551 for the related change.

We may be able to just remove the change because we already have a related code:

arrow/cpp/CMakeLists.txt

Lines 775 to 778 in 081b402

if(ORC_SOURCE STREQUAL "SYSTEM")
list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS orc::orc
${ARROW_PROTOBUF_LIBPROTOBUF})
endif()

Component(s)

C++
@kou kou added the Type: bug label Dec 8, 2023
@kou kou mentioned this issue Dec 8, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Dec 8, 2023
@kou
apacheGH-39136: [C++] Remove needless system Protobuf dependency with…
3b3a3f8 
… -DARROW_HDFS=ON
@github-actions github-actions bot mentioned this issue Dec 8, 2023
Merged
@kou kou closed this as completed in #39137 Dec 8, 2023
kou added a commit that referenced this issue Dec 8, 2023
@kou
GH-39136: [C++] Remove needless system Protobuf dependency with -DARR…
8a644af 
…OW_HDFS=ON (#39137)

### Rationale for this change

Our HDFS related codes don't depend on Protobuf because we process HDFS via external `libhdfs.so` and it's `dlopen()`-ed.

### What changes are included in this PR?

Remove a needless CMake configuration. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #39136

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Dec 8, 2023
mapleFU pushed a commit to mapleFU/arrow that referenced this issue Dec 13, 2023
@kou @mapleFU
apacheGH-39136: [C++] Remove needless system Protobuf dependency with…
991192c 
… -DARROW_HDFS=ON (apache#39137)

### Rationale for this change

Our HDFS related codes don't depend on Protobuf because we process HDFS via external `libhdfs.so` and it's `dlopen()`-ed.

### What changes are included in this PR?

Remove a needless CMake configuration. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39136

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@kou @clayburn
apacheGH-39136: [C++] Remove needless system Protobuf dependency with…
73d6c9b 
… -DARROW_HDFS=ON (apache#39137)

### Rationale for this change

Our HDFS related codes don't depend on Protobuf because we process HDFS via external `libhdfs.so` and it's `dlopen()`-ed.

### What changes are included in this PR?

Remove a needless CMake configuration. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39136

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-39136: [C++] Remove needless system Protobuf dependency with…
80aa87d 
… -DARROW_HDFS=ON (apache#39137)

### Rationale for this change

Our HDFS related codes don't depend on Protobuf because we process HDFS via external `libhdfs.so` and it's `dlopen()`-ed.

### What changes are included in this PR?

Remove a needless CMake configuration. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39136

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39136: [C++] Remove needless system Protobuf dependency with -DARROW_HDFS=ON kou/arrow
1 participant
@kou