[C++] Make Buffer::device_type_ non-optional #39159
Comments
felipecrv
added a commit
that referenced
this issue
Dec 11, 2023
### Rationale for this change Buffer should always have a device type. When unspecified, CPU can be assumed. ### What changes are included in this PR? A change of the member variable type and some adjustments. ### Are these changes tested? N/A. ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** `Buffer::device_type_` is now a `DeviceAllocationType` instead of a `std::optional<DeviceAllocationType>`. * Closes: #39159 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this issue
Dec 13, 2023
…pache#39150) ### Rationale for this change Buffer should always have a device type. When unspecified, CPU can be assumed. ### What changes are included in this PR? A change of the member variable type and some adjustments. ### Are these changes tested? N/A. ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** `Buffer::device_type_` is now a `DeviceAllocationType` instead of a `std::optional<DeviceAllocationType>`. * Closes: apache#39159 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this issue
Jan 23, 2024
…pache#39150) ### Rationale for this change Buffer should always have a device type. When unspecified, CPU can be assumed. ### What changes are included in this PR? A change of the member variable type and some adjustments. ### Are these changes tested? N/A. ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** `Buffer::device_type_` is now a `DeviceAllocationType` instead of a `std::optional<DeviceAllocationType>`. * Closes: apache#39159 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…pache#39150) ### Rationale for this change Buffer should always have a device type. When unspecified, CPU can be assumed. ### What changes are included in this PR? A change of the member variable type and some adjustments. ### Are these changes tested? N/A. ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** `Buffer::device_type_` is now a `DeviceAllocationType` instead of a `std::optional<DeviceAllocationType>`. * Closes: apache#39159 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
There is no need to wrap it in an
optionand if we are in a position where we can't determine the device type, "cpu" is probably the right default.Component(s)
C++
The text was updated successfully, but these errors were encountered: