Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Minor: Remove deprecated AppendRowGroup(int64_t num_rows) #39208

Closed
mapleFU opened this issue Dec 13, 2023 · 0 comments · Fixed by #39209
Closed

[C++][Parquet] Minor: Remove deprecated AppendRowGroup(int64_t num_rows) #39208

mapleFU opened this issue Dec 13, 2023 · 0 comments · Fixed by #39209
Assignees
@mapleFU
Labels
Component: C++ Component: Parquet Type: enhancement
Milestone
15.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Dec 13, 2023

Describe the enhancement requested

ParquetFileWriter::Contents::AppendRowGroup is mark as deprecated in 1.3.0, I'd like to remove it

    /// \note Deprecated since 1.3.0
    RowGroupWriter* AppendRowGroup(int64_t num_rows);

Component(s)

C++, Parquet
@github-actions github-actions bot mentioned this issue Dec 13, 2023
Merged
pitrou pushed a commit that referenced this issue Dec 13, 2023
@mapleFU
GH-39208: [C++][Parquet] Remove deprecated AppendRowGroup(int64_t num…
b5a4657 
…_rows) (#39209)

### Rationale for this change

Described in issue

### What changes are included in this PR?

Remove the function below:

```
    /// \note Deprecated since 1.3.0
    RowGroupWriter* AppendRowGroup(int64_t num_rows);
```

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: #39208

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 15.0.0 milestone Dec 13, 2023
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@mapleFU @clayburn
apacheGH-39208: [C++][Parquet] Remove deprecated AppendRowGroup(int64…
335b810 
…_t num_rows) (apache#39209)

### Rationale for this change

Described in issue

### What changes are included in this PR?

Remove the function below:

```
    /// \note Deprecated since 1.3.0
    RowGroupWriter* AppendRowGroup(int64_t num_rows);
```

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: apache#39208

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@mapleFU @dgreiss
apacheGH-39208: [C++][Parquet] Remove deprecated AppendRowGroup(int64…
9471a87 
…_t num_rows) (apache#39209)

### Rationale for this change

Described in issue

### What changes are included in this PR?

Remove the function below:

```
    /// \note Deprecated since 1.3.0
    RowGroupWriter* AppendRowGroup(int64_t num_rows);
```

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: apache#39208

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Component: Parquet Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39208: [C++][Parquet] Remove deprecated AppendRowGroup(int64_t num_rows) mapleFU/arrow
2 participants
@pitrou @mapleFU