You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…ultset (#39239)
### Rationale for this change
When having an empty resultset, the driver tries to include an empty record referece, that cannot be scanned.
So, any operation that relies on the returned Row(s) will trigger a "Index out of Range" error.
### What changes are included in this PR?
We're preventing to include an invalid record (that can't be scanned) in an empty resultset
### Are these changes tested?
Yes, there's a new test included
### Are there any user-facing changes?
No
**This PR contains a "Critical Fix".**
* Closes: #39238
Authored-by: miguel pragier <miguel.pragier@ebnerstolz.de>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
…ty resultset (apache#39239)
### Rationale for this change
When having an empty resultset, the driver tries to include an empty record referece, that cannot be scanned.
So, any operation that relies on the returned Row(s) will trigger a "Index out of Range" error.
### What changes are included in this PR?
We're preventing to include an invalid record (that can't be scanned) in an empty resultset
### Are these changes tested?
Yes, there's a new test included
### Are there any user-facing changes?
No
**This PR contains a "Critical Fix".**
* Closes: apache#39238
Authored-by: miguel pragier <miguel.pragier@ebnerstolz.de>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…ty resultset (apache#39239)
### Rationale for this change
When having an empty resultset, the driver tries to include an empty record referece, that cannot be scanned.
So, any operation that relies on the returned Row(s) will trigger a "Index out of Range" error.
### What changes are included in this PR?
We're preventing to include an invalid record (that can't be scanned) in an empty resultset
### Are these changes tested?
Yes, there's a new test included
### Are there any user-facing changes?
No
**This PR contains a "Critical Fix".**
* Closes: apache#39238
Authored-by: miguel pragier <miguel.pragier@ebnerstolz.de>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Describe the bug, including details regarding any error messages, version, and platform.
Description
When having an empty resultset, the driver tries to include an empty record referece, that cannot be scanned.
So, any operation that relies on the returned *Rows will trigger a "Index out of Range" error.
We wrote a patch that prevents empty records to be appended to the resultset.
Further Details
The error is detected here, when r.currentRecord is mistankely 1, when should be zero:
At:
/flight/flightsql/driver/driver.go:87
But happens here:
At:
/flight/flightsql/driver/driver.go:492
Platform, Arrow/Flight & Go
OS: Linux
Arrow Driver: github.com/apache/arrow/go/v14/arrow/flight/flightsql/driver
Go Version: go1.21.4 linux/amd64
Component(s)
Go
The text was updated successfully, but these errors were encountered: