Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][FlightSQL] Update Apache Avatica to version 1.24.0 #39288

Closed
rcprcp opened this issue Dec 18, 2023 · 8 comments · Fixed by #39325
Closed

[Java][FlightSQL] Update Apache Avatica to version 1.24.0 #39288

rcprcp opened this issue Dec 18, 2023 · 8 comments · Fixed by #39325

Comments

@rcprcp
Copy link
Contributor

rcprcp commented Dec 18, 2023

Describe the bug, including details regarding any error messages, version, and platform.

The Flight SQL JDBC driver link on mvnrepository

https://mvnrepository.com/artifact/org.apache.arrow/flight-sql-jdbc-driver/14.0.1

Links to these two CVE's:

Vulnerabilities from dependencies:
CVE-2023-2976
CVE-2020-8908

These CVEs are blocking a customer's ability to use the driver in production, as the customer's Security Team objects to having these move to production.

Is it possible to upgrade the dependencies, test, and release a new version of the driver without these CVEs?

Component(s)

Java

@kou kou changed the title Flight SQL JDBC Driver has 2 CVEs blocking adoption in a customer's production environment. [Java][FlightSQL] Flight SQL JDBC Driver has 2 CVEs blocking adoption in a customer's production environment. Dec 18, 2023
@danepitkin
Copy link
Member

Dependabot just upgraded the Guava lib to v32.1.3 307fbc5. One of the CVEs recommends upgrading to at least v32.0.1 so this might be fixed already. @rcprcp do you want to verify this resolves the issue?

@rcprcp
Copy link
Contributor Author

rcprcp commented Dec 19, 2023

Hi @danepitkin - thanks for picking up this issue so quickly.

Your help with this is greatly appreciated. 🥇

We realize now that there is one other important CVE that's included in flight-sql-jdbc-driver and we also need this one resolved as well:
https://nvd.nist.gov/vuln/detail/CVE-2022-36364

This vulnerability is introduced by the reference to Avatica v 1.18.0. In Avatica version 1.22.0 and above, this issue is resolved.

In https://mvnrepository.com/artifact/org.apache.calcite.avatica/avatica-core

Is it possible to also upgrade the Avatica dependency in the flight-sql-jdbc-driver?

Thank you for your help.

@danepitkin
Copy link
Member

Ah looks like Arrow is using v1.18:

JDBC Core

<version>1.18.0</version>

JDBC Driver
<version>1.18.0</version>

Would you be willing to help contribute a fix for this?

@rcprcp
Copy link
Contributor Author

rcprcp commented Dec 19, 2023

Hi @danepitkin - sure.

If by "fix," we mean to change the pom files, run a few local tests, and submit a PR.

Please let me know if there is more to this than I am considering.

Thanks

rcprcp added a commit to rcprcp/arrow that referenced this issue Dec 20, 2023
Update pom files, update several failing tests, because
UsernamePasswordCredentials() has been removed from Avatica.
@danepitkin
Copy link
Member

Yes, that's it! Thank you @rcprcp, I truly appreciate it.

Can we update the title/description of this issue to match the PR?

@rcprcp rcprcp changed the title [Java][FlightSQL] Flight SQL JDBC Driver has 2 CVEs blocking adoption in a customer's production environment. [Java][FlightSQL] Update Apache Avatica to version 1.24.0 Dec 20, 2023
@rcprcp
Copy link
Contributor Author

rcprcp commented Dec 20, 2023

@danepitkin thank you. Updated the issues's title.

lidavidm pushed a commit that referenced this issue Dec 20, 2023
…39325)

Updated pom files, and updated several failing tests because UsernamePasswordCredentials() method has been removed from Avatica.
* Closes: #39288

Authored-by: Bob Plotts <bob.plotts@dremio.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 15.0.0 milestone Dec 20, 2023
@rcprcp
Copy link
Contributor Author

rcprcp commented Dec 20, 2023

Hi @lidavidm , is there an approximate date when Arrow Flight V15 will be released? Or, if there is going to be a 14.3.0 version released sooner, can we get this issue backported? If we go with 14.3.0, is there an approximate date for that? thanks!

@lidavidm
Copy link
Member

Releases are roughly every 3 months. 14.3.0 is unlikely, 15.0.0 should be in January.

clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
…24.0 (apache#39325)

Updated pom files, and updated several failing tests because UsernamePasswordCredentials() method has been removed from Avatica.
* Closes: apache#39288

Authored-by: Bob Plotts <bob.plotts@dremio.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…24.0 (apache#39325)

Updated pom files, and updated several failing tests because UsernamePasswordCredentials() method has been removed from Avatica.
* Closes: apache#39288

Authored-by: Bob Plotts <bob.plotts@dremio.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants