Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Benchmarking] Remove hardcoded MinTime settings #39306

Closed
pitrou opened this issue Dec 19, 2023 · 0 comments · Fixed by #39307
Closed

[C++][Benchmarking] Remove hardcoded MinTime settings #39306

pitrou opened this issue Dec 19, 2023 · 0 comments · Fixed by #39307
Assignees
@pitrou
Labels
Component: Benchmarking Component: C++ Type: bug
Milestone
15.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Dec 19, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Some of our benchmarks hardcode the MinTime setting, preventing it from being overriden on the command line using the --benchmark_min_time option. We should remove all those hardcoded settings as they serve no useful purpose.

Component(s)

Benchmarking, C++
@pitrou pitrou self-assigned this Dec 19, 2023
pitrou added a commit to pitrou/arrow that referenced this issue Dec 19, 2023
@pitrou
apacheGH-39306: [C++][Benchmarking] Reduce hardcoded min times
fbbada9
@github-actions github-actions bot mentioned this issue Dec 19, 2023
Merged
@pitrou pitrou added this to the 15.0.0 milestone Dec 20, 2023
pitrou added a commit that referenced this issue Dec 20, 2023
@pitrou
GH-39306: [C++][Benchmarking] Remove hardcoded min times (#39307)
87865b5 
### Rationale for this change

`MinTime` settings hardcoded in the C++ source code prevent the `--benchmark_min_time` CLI option from working.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: #39306

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@pitrou @clayburn
apacheGH-39306: [C++][Benchmarking] Remove hardcoded min times (apach…
30235f6 
…e#39307)

### Rationale for this change

`MinTime` settings hardcoded in the C++ source code prevent the `--benchmark_min_time` CLI option from working.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#39306

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@pitrou @dgreiss
apacheGH-39306: [C++][Benchmarking] Remove hardcoded min times (apach…
88a6900 
…e#39307)

### Rationale for this change

`MinTime` settings hardcoded in the C++ source code prevent the `--benchmark_min_time` CLI option from working.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#39306

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: Benchmarking Component: C++ Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39306: [C++][Benchmarking] Remove hardcoded min times pitrou/arrow
1 participant
@pitrou