[C++][Parquet] Minor: Using arrow::Buffer "data_as" api to replace the reinterpret_cast #39419
Comments
mapleFU
added a commit
that referenced
this issue
Jan 5, 2024
…r than reinterpret_cast (#39420) ### Rationale for this change This patch using `{mutable}_data_as<T>()` api to replace `interpret_cast<{const} T*>`. It's just a style fixing. ### What changes are included in this PR? Just api replacement for `::arrow::Buffer` * `reinterpret_cast<T*>` -> `mutable_data_as<T>()` * `reinterpret_cast<const T*>` -> `data_as<T>()` Also, for `auto {variable_name} = reinterpret_cast<{mutable} T*>( ... )`, I changed it to: 1. `const auto*` for `data_as<T>()`. 2. `auto*` for `mutable_data_as<T>()` This didn't change the syntax, but make it more readable. ### Are these changes tested? No need ### Are there any user-facing changes? no * Closes: #39419 * Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this issue
Jan 23, 2024
… rather than reinterpret_cast (apache#39420) ### Rationale for this change This patch using `{mutable}_data_as<T>()` api to replace `interpret_cast<{const} T*>`. It's just a style fixing. ### What changes are included in this PR? Just api replacement for `::arrow::Buffer` * `reinterpret_cast<T*>` -> `mutable_data_as<T>()` * `reinterpret_cast<const T*>` -> `data_as<T>()` Also, for `auto {variable_name} = reinterpret_cast<{mutable} T*>( ... )`, I changed it to: 1. `const auto*` for `data_as<T>()`. 2. `auto*` for `mutable_data_as<T>()` This didn't change the syntax, but make it more readable. ### Are these changes tested? No need ### Are there any user-facing changes? no * Closes: apache#39419 * Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
… rather than reinterpret_cast (apache#39420) ### Rationale for this change This patch using `{mutable}_data_as<T>()` api to replace `interpret_cast<{const} T*>`. It's just a style fixing. ### What changes are included in this PR? Just api replacement for `::arrow::Buffer` * `reinterpret_cast<T*>` -> `mutable_data_as<T>()` * `reinterpret_cast<const T*>` -> `data_as<T>()` Also, for `auto {variable_name} = reinterpret_cast<{mutable} T*>( ... )`, I changed it to: 1. `const auto*` for `data_as<T>()`. 2. `auto*` for `mutable_data_as<T>()` This didn't change the syntax, but make it more readable. ### Are these changes tested? No need ### Are there any user-facing changes? no * Closes: apache#39419 * Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
… rather than reinterpret_cast (apache#39420) ### Rationale for this change This patch using `{mutable}_data_as<T>()` api to replace `interpret_cast<{const} T*>`. It's just a style fixing. ### What changes are included in this PR? Just api replacement for `::arrow::Buffer` * `reinterpret_cast<T*>` -> `mutable_data_as<T>()` * `reinterpret_cast<const T*>` -> `data_as<T>()` Also, for `auto {variable_name} = reinterpret_cast<{mutable} T*>( ... )`, I changed it to: 1. `const auto*` for `data_as<T>()`. 2. `auto*` for `mutable_data_as<T>()` This didn't change the syntax, but make it more readable. ### Are these changes tested? No need ### Are there any user-facing changes? no * Closes: apache#39419 * Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
A lots of reinterpret_cast api is used in Parquet decoder/encoder. Now that we has
{mutable}_data_as<T>api, we can using them to replace thereinterpret_castapi.Component(s)
C++, Parquet
The text was updated successfully, but these errors were encountered: