Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][JS] Verification jobs on M1 for JS fail to compile due to TypeError calling Function.prototype.apply on undefined #39469

Closed
raulcd opened this issue Jan 5, 2024 · 3 comments · Fixed by #39499

Comments

@raulcd
Copy link
Member

raulcd commented Jan 5, 2024

Describe the bug, including details regarding any error messages, version, and platform.

Our verification jobs for macOS ARM (M1) have been failing:

With the following error:

 [07:54:03] Error: [07:54:03] 
'compile:es2015:umd' errored after 2.04 ms
[07:54:03] TypeError: Function.prototype.apply was called on undefined, which is a undefined and not a function
    at Lo (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/esm/esm.js:1:233359)
    at au (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/esm/esm.js:1:236294)
    at ou (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/esm/esm.js:1:236969)
    at Module.<anonymous> (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/esm/esm.js:1:304731)
    at require (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/esm/esm.js:1:288360)
    at file:///Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/gulp/closure-task.js:46:46
    at Array.reduce (<anonymous>)
    at closure (file:///Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/gulp/closure-task.js:43:60)
    at fn (file:///Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/gulp/memoize-task.js:31:41)
    at compile (file:///Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/gulp/compile-task.js:30:86)
[07:54:03] 'compile' errored after 4.85 ms

    at formatError (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/gulp-cli/lib/versioned/^4.0.0/format-error.js:21:10)
    at Gulp.<anonymous> (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/gulp-cli/lib/versioned/^4.0.0/log/events.js:33:15)
    at Gulp.emit (node:events:531:35)
    at Gulp.emit (node:domain:488:12)
    at Object.error (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/undertaker/lib/helpers/createExtensions.js:61:10)
    at handler (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/now-and-later/lib/mapSeries.js:47:14)
    at f (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/once/once.js:25:25)
    at f (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/once/once.js:25:25)
    at tryCatch (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/bach/node_modules/async-done/index.js:24:15)
    at done (/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/js/node_modules/bach/node_modules/async-done/index.js:40:12)
[07:54:03] 'build:es2015:umd' errored after 23 s
[07:54:03] 'build:apache-arrow' errored after 23 s
[07:54:03] 'build' errored after 23 s
error Command failed with exit code 1.

M1's are self-hosted and might require to update a dependency manually but I am unsure on what the problem is.

Component(s)

Continuous Integration, JavaScript

@raulcd
Copy link
Member Author

raulcd commented Jan 5, 2024

cc @domoritz @trxcllnt

@raulcd raulcd added this to the 15.0.0 milestone Jan 5, 2024
@raulcd raulcd added the Priority: Blocker Marks a blocker for the release label Jan 5, 2024
@domoritz
Copy link
Member

domoritz commented Jan 5, 2024

Odd. It works locally for me with Node 20 but not Node 21. Could this be an issue in v8: tc39/ecma262#2343 (comment)?

@domoritz
Copy link
Member

domoritz commented Jan 5, 2024

It looks like we use node 21: Found NodeJS installation with version v21.5.x. Can we just downgrade to node 20 to make the release? I don't really know what's going on and it doesn't really matter since this is in the build script rather than Arrow itself so the version doesn't affect compatibility as far I can see.

raulcd added a commit to raulcd/arrow that referenced this issue Jan 8, 2024
@kou kou closed this as completed in #39499 Jan 8, 2024
kou pushed a commit that referenced this issue Jan 8, 2024
…sues (#39499)

### Rationale for this change

The nightly jobs are currently failing when using node v21 on macOS arm64.

### What changes are included in this PR?

Install and use node v20 for macOS arm64 jobs.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?
No
* Closes: #39469

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
…ild issues (apache#39499)

### Rationale for this change

The nightly jobs are currently failing when using node v21 on macOS arm64.

### What changes are included in this PR?

Install and use node v20 for macOS arm64 jobs.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?
No
* Closes: apache#39469

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…ild issues (apache#39499)

### Rationale for this change

The nightly jobs are currently failing when using node v21 on macOS arm64.

### What changes are included in this PR?

Install and use node v20 for macOS arm64 jobs.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?
No
* Closes: apache#39469

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
…ild issues (apache#39499)

### Rationale for this change

The nightly jobs are currently failing when using node v21 on macOS arm64.

### What changes are included in this PR?

Install and use node v20 for macOS arm64 jobs.

### Are these changes tested?

Yes via archery.

### Are there any user-facing changes?
No
* Closes: apache#39469

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants