Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Use node: prefix and import types instead of using import #39482

Closed
domoritz opened this issue Jan 5, 2024 · 0 comments · Fixed by #39483
Closed

[JS] Use node: prefix and import types instead of using import #39482

domoritz opened this issue Jan 5, 2024 · 0 comments · Fixed by #39483

Comments

@domoritz
Copy link
Member

domoritz commented Jan 5, 2024

Describe the enhancement requested

This should make the code more readable.

Component(s)

JavaScript

@domoritz domoritz self-assigned this Jan 5, 2024
domoritz added a commit to domoritz/arrow that referenced this issue Jan 5, 2024
domoritz added a commit that referenced this issue Apr 16, 2024
* use `node:` prefix for node imports
* remove `import` for types where it makes sense

* Closes: #39482
* GitHub Issue: #39482

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
@domoritz domoritz added this to the 16.0.0 milestone Apr 16, 2024
domoritz added a commit to domoritz/arrow that referenced this issue Apr 17, 2024
* use `node:` prefix for node imports
* remove `import` for types where it makes sense

* Closes: apache#39482
* GitHub Issue: apache#39482

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
@domoritz domoritz modified the milestones: 16.0.0, 16.1.0 Apr 18, 2024
@raulcd raulcd changed the title Use node: prefix and import types instead of using import [JS] Use node: prefix and import types instead of using import Apr 18, 2024
raulcd pushed a commit that referenced this issue Apr 29, 2024
* use `node:` prefix for node imports
* remove `import` for types where it makes sense

* Closes: #39482
* GitHub Issue: #39482

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
* use `node:` prefix for node imports
* remove `import` for types where it makes sense

* Closes: apache#39482
* GitHub Issue: apache#39482

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
* use `node:` prefix for node imports
* remove `import` for types where it makes sense

* Closes: apache#39482
* GitHub Issue: apache#39482

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
* use `node:` prefix for node imports
* remove `import` for types where it makes sense

* Closes: apache#39482
* GitHub Issue: apache#39482

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
* use `node:` prefix for node imports
* remove `import` for types where it makes sense

* Closes: apache#39482
* GitHub Issue: apache#39482

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
* use `node:` prefix for node imports
* remove `import` for types where it makes sense

* Closes: apache#39482
* GitHub Issue: apache#39482

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant