[Java] Support 256 bit Decimals in JdbcToArrowUtils #39484
Comments
lidavidm
pushed a commit
that referenced
this issue
Jan 8, 2024
### Rationale for this change This PR allows users of `JdbcToArrowUtils` to convert 256 bit decimals. ### What changes are included in this PR? Add a `Decimal256Consumer` and logic to ### Are these changes tested? No, at this point there are no good tests for JDBC consumers. ### Are there any user-facing changes? Converting 256 bit decimals and ints bigger than 64 bit should now work * Closes: #39484 Authored-by: Diego Fernandez <aiguo.fernandez@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this issue
Jan 23, 2024
…pache#39485) ### Rationale for this change This PR allows users of `JdbcToArrowUtils` to convert 256 bit decimals. ### What changes are included in this PR? Add a `Decimal256Consumer` and logic to ### Are these changes tested? No, at this point there are no good tests for JDBC consumers. ### Are there any user-facing changes? Converting 256 bit decimals and ints bigger than 64 bit should now work * Closes: apache#39484 Authored-by: Diego Fernandez <aiguo.fernandez@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…pache#39485) ### Rationale for this change This PR allows users of `JdbcToArrowUtils` to convert 256 bit decimals. ### What changes are included in this PR? Add a `Decimal256Consumer` and logic to ### Are these changes tested? No, at this point there are no good tests for JDBC consumers. ### Are there any user-facing changes? Converting 256 bit decimals and ints bigger than 64 bit should now work * Closes: apache#39484 Authored-by: Diego Fernandez <aiguo.fernandez@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
…pache#39485) ### Rationale for this change This PR allows users of `JdbcToArrowUtils` to convert 256 bit decimals. ### What changes are included in this PR? Add a `Decimal256Consumer` and logic to ### Are these changes tested? No, at this point there are no good tests for JDBC consumers. ### Are there any user-facing changes? Converting 256 bit decimals and ints bigger than 64 bit should now work * Closes: apache#39484 Authored-by: Diego Fernandez <aiguo.fernandez@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
The current implementation breaks when a Decimal column needs 256 bits (32 bytes). For example, BigQuery's BIGNUMERIC. There's already a
Decimal256Vectorso I believe we'd just need to add aDecimal256Consumerand add the logic for using it in a conversion.Component(s)
Java
The text was updated successfully, but these errors were encountered: