Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][CI] lto nightly fails because s2n-tls can't be build with lto #39523

Closed
assignUser opened this issue Jan 9, 2024 · 2 comments · Fixed by #39524
Closed

[R][CI] lto nightly fails because s2n-tls can't be build with lto #39523

assignUser opened this issue Jan 9, 2024 · 2 comments · Fixed by #39524
Assignees
@assignUser
Labels
Component: C++ Component: Continuous Integration Component: R Type: bug
Milestone
16.0.0

Comments

@assignUser
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

It seems the flag was changed so our exisitng removal no longer works https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=59395&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=3367cfe7-6aa5-5a88-c888-e6814d74f6eb&l=886
Failing compile command: g++ -E -I/usr/local/include -Wall -pedantic -flto -std=gnu++17 -xc++ -
See also #34349

Component(s)

C++, Continuous Integration, R
@assignUser assignUser self-assigned this Jan 9, 2024
@assignUser assignUser added this to the 15.0.0 milestone Jan 9, 2024
@assignUser assignUser added the Priority: Blocker Marks a blocker for the release label Jan 9, 2024
@assignUser
Copy link
Member Author

Marked as a blocker as this has been failing since 1 day AFTER the branch for 14.0.0 was cut. So it is likely that this hasn't occurred on CRAN because of that.

@github-actions github-actions bot mentioned this issue Jan 9, 2024
Merged
@assignUser assignUser removed the Priority: Blocker Marks a blocker for the release label Jan 9, 2024
@assignUser assignUser removed this from the 15.0.0 milestone Jan 9, 2024
@assignUser assignUser changed the title [C++][R][CI] lto nightly fails because s2n-tls can't be build with lto. [R][CI] Don't override explicitly set NOT_CRAN=false when on dev version. Jan 9, 2024
@assignUser assignUser changed the title [R][CI] Don't override explicitly set NOT_CRAN=false when on dev version. [R][CI] lto nightly fails because s2n-tls can't be build with lto Jan 9, 2024
@assignUser
Copy link
Member Author

This was caused by the build system setting NOT_CRAN=true unconditionally when on a dev version. This overrides the explicitly set envvar for the job causing aws components to be that don't support lto.

assignUser added a commit that referenced this issue Jan 12, 2024
@assignUser @kou
GH-39523: [R] Don't override explicitly set NOT_CRAN=false when on de…
3cc04f1 
…v version (#39524)

### Rationale for this change

The default linux build used in the lto job should not build with aws/gcs. A change in the build system changed this.

### What changes are included in this PR?

Revert to old behavior by not overriding explicitly set `NOT_CRAN=false`.

### Are these changes tested?

CI

### Are there any user-facing changes?

No
* Closes: #39523

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 16.0.0 milestone Jan 12, 2024
This was referenced Jan 12, 2024
Closed
Closed
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@assignUser @kou @clayburn
apacheGH-39523: [R] Don't override explicitly set NOT_CRAN=false when…
f6bbeeb 
… on dev version (apache#39524)

### Rationale for this change

The default linux build used in the lto job should not build with aws/gcs. A change in the build system changed this.

### What changes are included in this PR?

Revert to old behavior by not overriding explicitly set `NOT_CRAN=false`.

### Are these changes tested?

CI

### Are there any user-facing changes?

No
* Closes: apache#39523

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@assignUser @kou @dgreiss
apacheGH-39523: [R] Don't override explicitly set NOT_CRAN=false when…
d1caba9 
… on dev version (apache#39524)

### Rationale for this change

The default linux build used in the lto job should not build with aws/gcs. A change in the build system changed this.

### What changes are included in this PR?

Revert to old behavior by not overriding explicitly set `NOT_CRAN=false`.

### Are these changes tested?

CI

### Are there any user-facing changes?

No
* Closes: apache#39523

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@assignUser @kou @zanmato1984
apacheGH-39523: [R] Don't override explicitly set NOT_CRAN=false when…
40c2e1f 
… on dev version (apache#39524)

### Rationale for this change

The default linux build used in the lto job should not build with aws/gcs. A change in the build system changed this.

### What changes are included in this PR?

Revert to old behavior by not overriding explicitly set `NOT_CRAN=false`.

### Are these changes tested?

CI

### Are there any user-facing changes?

No
* Closes: apache#39523

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit that referenced this issue Mar 8, 2024
@assignUser @kou @thisisnic
GH-39523: [R] Don't override explicitly set NOT_CRAN=false when on de…
aa92597 
…v version (#39524)

### Rationale for this change

The default linux build used in the lto job should not build with aws/gcs. A change in the build system changed this.

### What changes are included in this PR?

Revert to old behavior by not overriding explicitly set `NOT_CRAN=false`.

### Are these changes tested?

CI

### Are there any user-facing changes?

No
* Closes: #39523

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@assignUser @kou @thisisnic
apacheGH-39523: [R] Don't override explicitly set NOT_CRAN=false when…
36e21ab 
… on dev version (apache#39524)

### Rationale for this change

The default linux build used in the lto job should not build with aws/gcs. A change in the build system changed this.

### What changes are included in this PR?

Revert to old behavior by not overriding explicitly set `NOT_CRAN=false`.

### Are these changes tested?

CI

### Are there any user-facing changes?

No
* Closes: apache#39523

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: C++ Component: Continuous Integration Component: R Type: bug
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39523: [R] Don't override explicitly set NOT_CRAN=false when on dev version assignUser/arrow
1 participant
@assignUser