Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Not all decoders are passed a memory pool from column reader #39525

Closed
emkornfield opened this issue Jan 9, 2024 · 1 comment · Fixed by #39526
Closed

[C++][Parquet] Not all decoders are passed a memory pool from column reader #39525

emkornfield opened this issue Jan 9, 2024 · 1 comment · Fixed by #39526
Assignees
@emkornfield
Labels
Component: C++ Component: Parquet Type: bug
Milestone
15.0.1

Comments

@emkornfield
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

This can prevent proper memory attribution/etc from occurring.

Component(s)

C++
@emkornfield
Copy link
Contributor Author

take

@emkornfield emkornfield self-assigned this Jan 9, 2024
@github-actions github-actions bot mentioned this issue Jan 9, 2024
Merged
mapleFU pushed a commit that referenced this issue Jan 11, 2024
@emkornfield
GH-39525: [C++][Parquet] Pass memory pool to decoders (#39526)
c009024 
### Rationale for this change

Memory pools should be plumbed through where ever possible.

### What changes are included in this PR?

Pass through memory pool to decoders

### Are these changes tested?

Not directly; this was caught via some internal fuzz targets.

### Are there any user-facing changes?

No.

* Closes: #39525

Authored-by: Micah Kornfield <micahk@google.com>
Signed-off-by: mwish <maplewish117@gmail.com>
@mapleFU mapleFU added this to the 16.0.0 milestone Jan 11, 2024
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@emkornfield @clayburn
apacheGH-39525: [C++][Parquet] Pass memory pool to decoders (apache#3…
7ce53c0 
…9526)

### Rationale for this change

Memory pools should be plumbed through where ever possible.

### What changes are included in this PR?

Pass through memory pool to decoders

### Are these changes tested?

Not directly; this was caught via some internal fuzz targets.

### Are there any user-facing changes?

No.

* Closes: apache#39525

Authored-by: Micah Kornfield <micahk@google.com>
Signed-off-by: mwish <maplewish117@gmail.com>
@pitrou pitrou modified the milestones: 16.0.0, 15.0.1 Feb 14, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@emkornfield @dgreiss
apacheGH-39525: [C++][Parquet] Pass memory pool to decoders (apache#3…
43bcab2 
…9526)

### Rationale for this change

Memory pools should be plumbed through where ever possible.

### What changes are included in this PR?

Pass through memory pool to decoders

### Are these changes tested?

Not directly; this was caught via some internal fuzz targets.

### Are there any user-facing changes?

No.

* Closes: apache#39525

Authored-by: Micah Kornfield <micahk@google.com>
Signed-off-by: mwish <maplewish117@gmail.com>
raulcd pushed a commit that referenced this issue Feb 20, 2024
@emkornfield @raulcd
GH-39525: [C++][Parquet] Pass memory pool to decoders (#39526)
75c9e02 
### Rationale for this change

Memory pools should be plumbed through where ever possible.

### What changes are included in this PR?

Pass through memory pool to decoders

### Are these changes tested?

Not directly; this was caught via some internal fuzz targets.

### Are there any user-facing changes?

No.

* Closes: #39525

Authored-by: Micah Kornfield <micahk@google.com>
Signed-off-by: mwish <maplewish117@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@emkornfield @zanmato1984
apacheGH-39525: [C++][Parquet] Pass memory pool to decoders (apache#3…
1cd8761 
…9526)

### Rationale for this change

Memory pools should be plumbed through where ever possible.

### What changes are included in this PR?

Pass through memory pool to decoders

### Are these changes tested?

Not directly; this was caught via some internal fuzz targets.

### Are there any user-facing changes?

No.

* Closes: apache#39525

Authored-by: Micah Kornfield <micahk@google.com>
Signed-off-by: mwish <maplewish117@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@emkornfield @thisisnic
apacheGH-39525: [C++][Parquet] Pass memory pool to decoders (apache#3…
a530d99 
…9526)

### Rationale for this change

Memory pools should be plumbed through where ever possible.

### What changes are included in this PR?

Pass through memory pool to decoders

### Are these changes tested?

Not directly; this was caught via some internal fuzz targets.

### Are there any user-facing changes?

No.

* Closes: apache#39525

Authored-by: Micah Kornfield <micahk@google.com>
Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emkornfield emkornfield

Labels
Component: C++ Component: Parquet Type: bug
Projects
None yet
Milestone
15.0.1
Development

Successfully merging a pull request may close this issue.

GH-39525: [C++][Parquet] Pass memory pool to decoders emkornfield/arrow
3 participants
@pitrou @emkornfield @mapleFU