Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Java][Release] java-jars is failing on maintenance branch because arrow-bom is not found on https://repository.apache.org/snapshots #39564

Closed
raulcd opened this issue Jan 11, 2024 · 9 comments · Fixed by #39580

Comments

@raulcd
Copy link
Member

raulcd commented Jan 11, 2024

Describe the bug, including details regarding any error messages, version, and platform.

There seems to be an issue building java-jars on the maintenance branch because org.apache.arrow:arrow-bom:pom:14.0.1-SNAPSHOT cannot be found on apache.snapshots (https://repository.apache.org/snapshots)

 ~/work/crossbow/crossbow/arrow/java ~/work/crossbow/crossbow
gpg: directory '/Users/runner/.gnupg' created
gpg: /Users/runner/.gnupg/trustdb.gpg: trustdb created
gpg: directory '/Users/runner/.gnupg/openpgp-revocs.d' created
gpg: revocation certificate stored as '/Users/runner/.gnupg/openpgp-revocs.d/AEC4AB3E371C97789461AF85687223BA9FD35D5A.rev'
[INFO] Scanning for projects...
Downloading from apache.snapshots: https://repository.apache.org/snapshots/org/apache/arrow/arrow-bom/14.0.1-SNAPSHOT/maven-metadata.xml
Downloading from apache.snapshots: https://repository.apache.org/snapshots/org/apache/arrow/arrow-bom/14.0.1-SNAPSHOT/arrow-bom-14.0.1-SNAPSHOT.pom
Error: ] Some problems were encountered while processing the POMs:
Error:  Non-resolvable import POM: The following artifacts could not be resolved: org.apache.arrow:arrow-bom:pom:14.0.1-SNAPSHOT (absent): Could not find artifact org.apache.arrow:arrow-bom:pom:14.0.1-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) @ line 602, column 19
 @ 
Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project org.apache.arrow:arrow-java-root:14.0.1-SNAPSHOT (/Users/runner/work/crossbow/crossbow/arrow/java/pom.xml) has 1 error
Error:      Non-resolvable import POM: The following artifacts could not be resolved: org.apache.arrow:arrow-bom:pom:14.0.1-SNAPSHOT (absent): Could not find artifact org.apache.arrow:arrow-bom:pom:14.0.1-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) @ line 602, column 19 -> [Help 2]

Component(s)

Continuous Integration, Java

@raulcd
Copy link
Member Author

raulcd commented Jan 11, 2024

From my understanding this is expected as the arrow-bom was added on this release:
#38264
We should not check that pom on the snapshots, right? @lidavidm @jduo @kou

@raulcd raulcd added this to the 15.0.0 milestone Jan 11, 2024
@raulcd raulcd added the Priority: Blocker Marks a blocker for the release label Jan 11, 2024
@raulcd
Copy link
Member Author

raulcd commented Jan 11, 2024

@kou
Copy link
Member

kou commented Jan 11, 2024

Hmm. It seems that 15.0.0-SNAPSHOT and 14.0.1-SNAPSHOT are mixed. It may be a problem...

@raulcd
Copy link
Member Author

raulcd commented Jan 11, 2024

I can't seem to find any occurrence on our repo about 14.0.1-SNAPSHOT.

@lidavidm
Copy link
Member

Why is it setting the version to 14.0.1-SNAPSHOT? (Not that that's related...)

It seems that after mvn versions:set, the version in bom/pom.xml is not updated like the rest. And the root pom.xml defines a dependency on arrow-bom version 14.0.1. I think that is where it is coming from. If I update bom/pom.xml to version 14.0.1, then the build proceeds. (However, it fails with a very similar issue in module-info-compiler-maven-plugin.) If I don't, the build fails.

@lidavidm
Copy link
Member

The build seems OK if I fix all versions in bom/pom.xml, maven/pom.xml, and maven/module-info-compiler-maven-plugin/pom.xml.

@lidavidm
Copy link
Member

However, I can't get mvn versions:set to do this for me even if I explicitly invoke it on the bom pom

@lidavidm
Copy link
Member

Oh, actually, this seems to work

mvn versions:set -DnewVersion=14.0.1-SNAPSHOT # we already do this in the job
mvn versions:set -DnewVersion=14.0.1-SNAPSHOT -f bom
mvn versions:set -DnewVersion=14.0.1-SNAPSHOT -f maven

The latter two commands will print an error but seem to pass and update the versions properly.

@lidavidm
Copy link
Member

So I think this would work:

diff --git a/dev/tasks/java-jars/github.yml b/dev/tasks/java-jars/github.yml
index fbce12ee4..7ee68e77e 100644
--- a/dev/tasks/java-jars/github.yml
+++ b/dev/tasks/java-jars/github.yml
@@ -236,6 +236,8 @@ jobs:
           set -e
           pushd arrow/java
           mvn versions:set -DnewVersion={{ arrow.no_rc_snapshot_version }}
+          mvn versions:set -DnewVersion={{ arrow.no_rc_snapshot_version }} -f bom
+          mvn versions:set -DnewVersion={{ arrow.no_rc_snapshot_version }} -f maven
           popd
           arrow/ci/scripts/java_full_build.sh \
             $GITHUB_WORKSPACE/arrow \

raulcd added a commit to raulcd/arrow that referenced this issue Jan 12, 2024
raulcd added a commit that referenced this issue Jan 12, 2024
### Rationale for this change

The version set currently on the maintenance branch is incorrect for Java BOM.

### What changes are included in this PR?

Suggested changes to set specifically version for BOM and maven.

### Are these changes tested?

I will trigger java-jars via archery but I think this is currently only reproducible on the maintenance branch. So we will have to merge and validate there.

### Are there any user-facing changes?
No
* Closes: #39564

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
raulcd added a commit that referenced this issue Jan 12, 2024
### Rationale for this change

The version set currently on the maintenance branch is incorrect for Java BOM.

### What changes are included in this PR?

Suggested changes to set specifically version for BOM and maven.

### Are these changes tested?

I will trigger java-jars via archery but I think this is currently only reproducible on the maintenance branch. So we will have to merge and validate there.

### Are there any user-facing changes?
No
* Closes: #39564

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
)

### Rationale for this change

The version set currently on the maintenance branch is incorrect for Java BOM.

### What changes are included in this PR?

Suggested changes to set specifically version for BOM and maven.

### Are these changes tested?

I will trigger java-jars via archery but I think this is currently only reproducible on the maintenance branch. So we will have to merge and validate there.

### Are there any user-facing changes?
No
* Closes: apache#39564

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
)

### Rationale for this change

The version set currently on the maintenance branch is incorrect for Java BOM.

### What changes are included in this PR?

Suggested changes to set specifically version for BOM and maven.

### Are these changes tested?

I will trigger java-jars via archery but I think this is currently only reproducible on the maintenance branch. So we will have to merge and validate there.

### Are there any user-facing changes?
No
* Closes: apache#39564

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
)

### Rationale for this change

The version set currently on the maintenance branch is incorrect for Java BOM.

### What changes are included in this PR?

Suggested changes to set specifically version for BOM and maven.

### Are these changes tested?

I will trigger java-jars via archery but I think this is currently only reproducible on the maintenance branch. So we will have to merge and validate there.

### Are there any user-facing changes?
No
* Closes: apache#39564

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
)

### Rationale for this change

The version set currently on the maintenance branch is incorrect for Java BOM.

### What changes are included in this PR?

Suggested changes to set specifically version for BOM and maven.

### Are these changes tested?

I will trigger java-jars via archery but I think this is currently only reproducible on the maintenance branch. So we will have to merge and validate there.

### Are there any user-facing changes?
No
* Closes: apache#39564

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants