Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] exception not being raised if passed an invalid partitiong on _ensure_partitioning #39579

Closed
idailylife opened this issue Jan 12, 2024 · 0 comments · Fixed by #39593
Closed

[Python] exception not being raised if passed an invalid partitiong on _ensure_partitioning #39579

idailylife opened this issue Jan 12, 2024 · 0 comments · Fixed by #39593
Assignees
@idailylife
Labels
Component: Python Type: bug
Milestone
16.0.0

Comments

@idailylife
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

It seems to be a typo at line 295 of python/pyarrow/dataset.py, which misses a "raise"

def _ensure_partitioning(scheme):
    ...
    else:
        ValueError(...)

# which should be
    else:
        raise ValueError(...)

Component(s)

Python
@github-actions github-actions bot mentioned this issue Jan 14, 2024
Merged
AlenkaF added a commit that referenced this issue Jan 22, 2024
@idailylife @AlenkaF
GH-39579: [Python] fix raising ValueError on _ensure_partitioning (#3…
a7f8140 
…9593)

### Rationale for this change
The `_ensure_partitioning` method in dataset.py is missing a "raise" which currently ignores bad scheme silently.

### What changes are included in this PR?

Fixed the typo.

### Are these changes tested?
Tried with new code that the exception is properly raised.

### Are there any user-facing changes?
No.

* Closes: #39579

Lead-authored-by: idailylife <iorange@126.com>
Co-authored-by: 0x0000ffff <idailylife@users.noreply.github.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
@AlenkaF AlenkaF added this to the 16.0.0 milestone Jan 22, 2024
@kou kou changed the title exception not being raised if passed an invalid partitiong on _ensure_partitioning [Python] exception not being raised if passed an invalid partitiong on _ensure_partitioning Jan 22, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@idailylife @AlenkaF @dgreiss
apacheGH-39579: [Python] fix raising ValueError on _ensure_partitioni…
b4d165e 
…ng (apache#39593)

### Rationale for this change
The `_ensure_partitioning` method in dataset.py is missing a "raise" which currently ignores bad scheme silently.

### What changes are included in this PR?

Fixed the typo.

### Are these changes tested?
Tried with new code that the exception is properly raised.

### Are there any user-facing changes?
No.

* Closes: apache#39579

Lead-authored-by: idailylife <iorange@126.com>
Co-authored-by: 0x0000ffff <idailylife@users.noreply.github.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@idailylife @AlenkaF @zanmato1984
apacheGH-39579: [Python] fix raising ValueError on _ensure_partitioni…
b7cc18c 
…ng (apache#39593)

### Rationale for this change
The `_ensure_partitioning` method in dataset.py is missing a "raise" which currently ignores bad scheme silently.

### What changes are included in this PR?

Fixed the typo.

### Are these changes tested?
Tried with new code that the exception is properly raised.

### Are there any user-facing changes?
No.

* Closes: apache#39579

Lead-authored-by: idailylife <iorange@126.com>
Co-authored-by: 0x0000ffff <idailylife@users.noreply.github.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@idailylife @AlenkaF @thisisnic
apacheGH-39579: [Python] fix raising ValueError on _ensure_partitioni…
d8ae416 
…ng (apache#39593)

### Rationale for this change
The `_ensure_partitioning` method in dataset.py is missing a "raise" which currently ignores bad scheme silently.

### What changes are included in this PR?

Fixed the typo.

### Are these changes tested?
Tried with new code that the exception is properly raised.

### Are there any user-facing changes?
No.

* Closes: apache#39579

Lead-authored-by: idailylife <iorange@126.com>
Co-authored-by: 0x0000ffff <idailylife@users.noreply.github.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idailylife idailylife

Labels
Component: Python Type: bug
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39579: [Python] fix raising ValueError on _ensure_partitioning idailylife/arrow
2 participants
@idailylife @AlenkaF