Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Disable parallelism for all make-based externalProjects when CMake >= 3.28 is used #39628

Closed
assignUser opened this issue Jan 16, 2024 · 3 comments · Fixed by #39629
Closed

[C++] Disable parallelism for all make-based externalProjects when CMake >= 3.28 is used #39628

assignUser opened this issue Jan 16, 2024 · 3 comments · Fixed by #39629
Assignees
@assignUser
Labels
Component: C++ Priority: Blocker Marks a blocker for the release Type: bug
Milestone
15.0.0

Comments

@assignUser
Copy link
Member

assignUser commented Jan 16, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Follow up to #39517 and #39550. Pass -j1 to all make-based externalProjects when CMake version is >3.28.

Component(s)

C++
@assignUser assignUser added this to the 15.0.0 milestone Jan 16, 2024
@assignUser assignUser added the Priority: Blocker Marks a blocker for the release label Jan 16, 2024
@assignUser
Copy link
Member Author

same failure in bzip2 build with previous fix: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=59776&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=6c939d89-0d1a-51f2-8b30-091a7a82e98c&l=966

@assignUser assignUser mentioned this issue Jan 16, 2024
Merged
@github-actions github-actions bot mentioned this issue Jan 16, 2024
Merged
@pitrou
Copy link
Member

pitrou commented Jan 16, 2024

Is there an upstream CMake bug open?

@assignUser
Copy link
Member Author

assignUser commented Jan 16, 2024 •
edited
Loading

No as I still haven't had time to get a reproducer working but I'll just open one with the arrow build as example :D

assignUser added a commit that referenced this issue Jan 16, 2024
@assignUser
GH-39628: [C++] Use -j1 for cmake >= 3.28 (#39629)
980e7d7 
### Rationale for this change

Prevent 'bad file descriptor' issue.

### What changes are included in this PR?

Use -j1 for make on CMake >= 3.28

### Are these changes tested?
Crossbow
* Closes: #39628

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
assignUser added a commit that referenced this issue Jan 17, 2024
@assignUser
GH-39628: [C++] Use -j1 for cmake >= 3.28 (#39629)
4a239b6 
### Rationale for this change

Prevent 'bad file descriptor' issue.

### What changes are included in this PR?

Use -j1 for make on CMake >= 3.28

### Are these changes tested?
Crossbow
* Closes: #39628

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
idailylife pushed a commit to idailylife/arrow that referenced this issue Jan 18, 2024
@assignUser @idailylife
apacheGH-39628: [C++] Use -j1 for cmake >= 3.28 (apache#39629)
b676728 
### Rationale for this change

Prevent 'bad file descriptor' issue.

### What changes are included in this PR?

Use -j1 for make on CMake >= 3.28

### Are these changes tested?
Crossbow
* Closes: apache#39628

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
pitrou added a commit that referenced this issue Jan 22, 2024
@pitrou
Revert "GH-39628: [C++] Use -j1 for cmake >= 3.28"
7792f40
pitrou added a commit that referenced this issue Jan 23, 2024
@pitrou
MINOR: Revert "GH-39628: [C++] Use -j1 for cmake >= 3.28" (#39736)
015c2d6 
Revert #39629: it makes all builds using CMake >= 3.28 much slower, while only addressing a very specific build failure. Hopefully we can find a more targeted workaround.

Authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@assignUser @clayburn
apacheGH-39628: [C++] Use -j1 for cmake >= 3.28 (apache#39629)
b90e5b2 
### Rationale for this change

Prevent 'bad file descriptor' issue.

### What changes are included in this PR?

Use -j1 for make on CMake >= 3.28

### Are these changes tested?
Crossbow
* Closes: apache#39628

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@assignUser @dgreiss
apacheGH-39628: [C++] Use -j1 for cmake >= 3.28 (apache#39629)
292bb04 
### Rationale for this change

Prevent 'bad file descriptor' issue.

### What changes are included in this PR?

Use -j1 for make on CMake >= 3.28

### Are these changes tested?
Crossbow
* Closes: apache#39628

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@pitrou @dgreiss
MINOR: Revert "apacheGH-39628: [C++] Use -j1 for cmake >= 3.28" (apac…
52118e6 
…he#39736)

Revert apache#39629: it makes all builds using CMake >= 3.28 much slower, while only addressing a very specific build failure. Hopefully we can find a more targeted workaround.

Authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@assignUser @zanmato1984
apacheGH-39628: [C++] Use -j1 for cmake >= 3.28 (apache#39629)
e0aab08 
### Rationale for this change

Prevent 'bad file descriptor' issue.

### What changes are included in this PR?

Use -j1 for make on CMake >= 3.28

### Are these changes tested?
Crossbow
* Closes: apache#39628

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@pitrou @zanmato1984
MINOR: Revert "apacheGH-39628: [C++] Use -j1 for cmake >= 3.28" (apac…
de4f977 
…he#39736)

Revert apache#39629: it makes all builds using CMake >= 3.28 much slower, while only addressing a very specific build failure. Hopefully we can find a more targeted workaround.

Authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@assignUser @thisisnic
apacheGH-39628: [C++] Use -j1 for cmake >= 3.28 (apache#39629)
b2bbc8e 
### Rationale for this change

Prevent 'bad file descriptor' issue.

### What changes are included in this PR?

Use -j1 for make on CMake >= 3.28

### Are these changes tested?
Crossbow
* Closes: apache#39628

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@pitrou @thisisnic
MINOR: Revert "apacheGH-39628: [C++] Use -j1 for cmake >= 3.28" (apac…
dc2a60f 
…he#39736)

Revert apache#39629: it makes all builds using CMake >= 3.28 much slower, while only addressing a very specific build failure. Hopefully we can find a more targeted workaround.

Authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: C++ Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-39628: [C++] Use -j1 for cmake >= 3.28 assignUser/arrow
2 participants
@pitrou @assignUser