[C++] Acero benchmarks should present a items/s or bytes/s metric #39664
Comments
7 tasks
|
take |
|
I checked the benchmarks to confirm the metrics for the Acero. aggregateresultasof-joinresultexpressionresultfilterresultprojectresulttpch
|
westonpace
pushed a commit
that referenced
this issue
Apr 22, 2024
…dentifying throughput (#40884) ### Rationale for this change Acero benchmarks sometimes output metrics such as `items/s`, `bytes/s`, `batches/s`, and `rows/s`. However, there is inconsistency in how these metrics are presented across different benchmarks. We are undertaking an effort to standardize the output of these metrics to ensure uniformity and clarity in performance measurement across all Acero benchmarks. ### What changes are included in this PR? `rows/s` has a similar meaning to `items/s`. - `bytes/s` and `items/s`: aggregate - `bytes/s` and `rows/s`: asof_join - `batches/s` and `rows/s`: project, filter, expression ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #39664 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
|
Issue resolved by pull request 40884 |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Apr 24, 2024
… for identifying throughput (apache#40884) ### Rationale for this change Acero benchmarks sometimes output metrics such as `items/s`, `bytes/s`, `batches/s`, and `rows/s`. However, there is inconsistency in how these metrics are presented across different benchmarks. We are undertaking an effort to standardize the output of these metrics to ensure uniformity and clarity in performance measurement across all Acero benchmarks. ### What changes are included in this PR? `rows/s` has a similar meaning to `items/s`. - `bytes/s` and `items/s`: aggregate - `bytes/s` and `rows/s`: asof_join - `batches/s` and `rows/s`: project, filter, expression ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#39664 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
raulcd
pushed a commit
that referenced
this issue
Apr 29, 2024
…dentifying throughput (#40884) ### Rationale for this change Acero benchmarks sometimes output metrics such as `items/s`, `bytes/s`, `batches/s`, and `rows/s`. However, there is inconsistency in how these metrics are presented across different benchmarks. We are undertaking an effort to standardize the output of these metrics to ensure uniformity and clarity in performance measurement across all Acero benchmarks. ### What changes are included in this PR? `rows/s` has a similar meaning to `items/s`. - `bytes/s` and `items/s`: aggregate - `bytes/s` and `rows/s`: asof_join - `batches/s` and `rows/s`: project, filter, expression ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #39664 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this issue
May 2, 2024
… for identifying throughput (apache#40884) ### Rationale for this change Acero benchmarks sometimes output metrics such as `items/s`, `bytes/s`, `batches/s`, and `rows/s`. However, there is inconsistency in how these metrics are presented across different benchmarks. We are undertaking an effort to standardize the output of these metrics to ensure uniformity and clarity in performance measurement across all Acero benchmarks. ### What changes are included in this PR? `rows/s` has a similar meaning to `items/s`. - `bytes/s` and `items/s`: aggregate - `bytes/s` and `rows/s`: asof_join - `batches/s` and `rows/s`: project, filter, expression ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#39664 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this issue
May 25, 2024
… for identifying throughput (apache#40884) ### Rationale for this change Acero benchmarks sometimes output metrics such as `items/s`, `bytes/s`, `batches/s`, and `rows/s`. However, there is inconsistency in how these metrics are presented across different benchmarks. We are undertaking an effort to standardize the output of these metrics to ensure uniformity and clarity in performance measurement across all Acero benchmarks. ### What changes are included in this PR? `rows/s` has a similar meaning to `items/s`. - `bytes/s` and `items/s`: aggregate - `bytes/s` and `rows/s`: asof_join - `batches/s` and `rows/s`: project, filter, expression ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#39664 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
We should scan through these benchmarks and look for those that only a present an iteration time.
Component(s)
Benchmarking, C++
The text was updated successfully, but these errors were encountered: