Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Gandiva] Support LLVM-18 #39928

Closed
MehdiChinoune opened this issue Feb 3, 2024 · 0 comments · Fixed by #39934
Closed

[C++][Gandiva] Support LLVM-18 #39928

MehdiChinoune opened this issue Feb 3, 2024 · 0 comments · Fixed by #39934

Comments

@MehdiChinoune
Copy link

Describe the enhancement requested

LLVM-18 will be released soon. Maybe consider supporting it
It fails even I added 18.1 as supported

--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -152,6 +152,7 @@
 set(BUILD_SUPPORT_DIR "${CMAKE_SOURCE_DIR}/build-support")
 
 set(ARROW_LLVM_VERSIONS
+    "18.1"
     "17.0"
     "16.0"
     "15.0"

this is the failure:

  [756/846] Building CXX object src/gandiva/CMakeFiles/gandiva_shared.dir/engine.cc.obj
  FAILED: src/gandiva/CMakeFiles/gandiva_shared.dir/engine.cc.obj 
  C:\msys64\ucrt64\bin\g++.exe -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_WITH_RE2 -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC -DAWS_AUTH_USE_IMPORT_EXPORT -DAWS_CAL_USE_IMPORT_EXPORT -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_COMPRESSION_USE_IMPORT_EXPORT -DAWS_CRT_CPP_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_HTTP_USE_IMPORT_EXPORT -DAWS_IO_USE_IMPORT_EXPORT -DAWS_MQTT_USE_IMPORT_EXPORT -DAWS_S3_USE_IMPORT_EXPORT -DAWS_SDKUTILS_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11 -DAWS_SDK_VERSION_PATCH=247 -DAWS_USE_IO_COMPLETION_PORTS -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB -DBOOST_USE_WINDOWS_H=1 -DGANDIVA_EXPORTING -DUSE_IMPORT_EXPORT -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -Dgandiva_shared_EXPORTS -IC:/_/B/src/build-UCRT64-cpp/src -IC:/_/B/src/apache-arrow-15.0.0/cpp/src -IC:/_/B/src/apache-arrow-15.0.0/cpp/src/generated -isystem C:/_/B/src/apache-arrow-15.0.0/cpp/thirdparty/flatbuffers/include -isystem C:/_/B/src/apache-arrow-15.0.0/cpp/thirdparty/hadoop/include -Wno-noexcept-type -Wno-self-move -march=nocona -msahf -mtune=generic -O2 -pipe -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong -fdiagnostics-color=always  -Wa,-mbig-obj -Wall -fno-semantic-interposition -mxsave -msse4.2  -O3 -DNDEBUG -O2 -ftree-vectorize  -std=c++17 -MD -MT src/gandiva/CMakeFiles/gandiva_shared.dir/engine.cc.obj -MF src\gandiva\CMakeFiles\gandiva_shared.dir\engine.cc.obj.d -o src/gandiva/CMakeFiles/gandiva_shared.dir/engine.cc.obj -c C:/_/B/src/apache-arrow-15.0.0/cpp/src/gandiva/engine.cc
  C:/_/B/src/apache-arrow-15.0.0/cpp/src/gandiva/engine.cc:65:10: fatal error: llvm/Support/Host.h: No such file or directory
     65 | #include <llvm/Support/Host.h>
        |          ^~~~~~~~~~~~~~~~~~~~~
  compilation terminated.

Component(s)

C++ - Gandiva

@kou kou changed the title Support LLVM-18 [C++][Gandiva] Support LLVM-18 Feb 3, 2024
kou added a commit to kou/arrow that referenced this issue Feb 4, 2024
@kou kou closed this as completed in #39934 Feb 5, 2024
kou added a commit that referenced this issue Feb 5, 2024
### Rationale for this change

LLVM 18.1 will be released soon.

### What changes are included in this PR?

Accept LLVM 18.1.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #39928

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 16.0.0 milestone Feb 5, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
### Rationale for this change

LLVM 18.1 will be released soon.

### What changes are included in this PR?

Accept LLVM 18.1.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39928

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
### Rationale for this change

LLVM 18.1 will be released soon.

### What changes are included in this PR?

Accept LLVM 18.1.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39928

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
### Rationale for this change

LLVM 18.1 will be released soon.

### What changes are included in this PR?

Accept LLVM 18.1.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39928

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants