Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Small CSV reader refactoring #39962

Closed
pitrou opened this issue Feb 6, 2024 · 0 comments · Fixed by #39963
Closed

[C++] Small CSV reader refactoring #39962

pitrou opened this issue Feb 6, 2024 · 0 comments · Fixed by #39963
Assignees
@pitrou
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Feb 6, 2024

Describe the enhancement requested

In #39892 I added a TODO noting that BlockParsingOperator::operator() was almost the same code as ReaderMixin::Parse(). We should factor out this common functionality to reduce code duplication.

Component(s)

C++
pitrou added a commit to pitrou/arrow that referenced this issue Feb 6, 2024
@pitrou
apacheGH-39962: [C++] Small CSV reader refactoring
f8b9e84
@github-actions github-actions bot mentioned this issue Feb 6, 2024
Merged
pitrou added a commit to pitrou/arrow that referenced this issue Feb 7, 2024
@pitrou
apacheGH-39962: [C++] Small CSV reader refactoring
7284df9
pitrou added a commit to pitrou/arrow that referenced this issue Feb 8, 2024
@pitrou
apacheGH-39962: [C++] Small CSV reader refactoring
0e38d20
pitrou added a commit to pitrou/arrow that referenced this issue Feb 8, 2024
@pitrou
apacheGH-39962: [C++] Small CSV reader refactoring
b0296de
pitrou added a commit that referenced this issue Feb 8, 2024
@pitrou
GH-39962: [C++] Small CSV reader refactoring (#39963)
de3cdc0 
### What changes are included in this PR?

Factor our some shared functionality in the CSV reader to avoid code duplication.

### Are these changes tested?

Yes, by existing tests.

### Are there any user-facing changes?

No.

* Closes: #39962

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 16.0.0 milestone Feb 8, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@pitrou @dgreiss
apacheGH-39962: [C++] Small CSV reader refactoring (apache#39963)
70a4131 
### What changes are included in this PR?

Factor our some shared functionality in the CSV reader to avoid code duplication.

### Are these changes tested?

Yes, by existing tests.

### Are there any user-facing changes?

No.

* Closes: apache#39962

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@pitrou @zanmato1984
apacheGH-39962: [C++] Small CSV reader refactoring (apache#39963)
5c4db4c 
### What changes are included in this PR?

Factor our some shared functionality in the CSV reader to avoid code duplication.

### Are these changes tested?

Yes, by existing tests.

### Are there any user-facing changes?

No.

* Closes: apache#39962

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@pitrou @thisisnic
apacheGH-39962: [C++] Small CSV reader refactoring (apache#39963)
c2a9282 
### What changes are included in this PR?

Factor our some shared functionality in the CSV reader to avoid code duplication.

### Are these changes tested?

Yes, by existing tests.

### Are there any user-facing changes?

No.

* Closes: apache#39962

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39962: [C++] Small CSV reader refactoring pitrou/arrow
1 participant
@pitrou