New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] ASAN reports heap buffer overflow in TestArray.TestAppendArraySlice
#39976
Labels
Component: C++
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
Type: bug
Milestone
Comments
take |
pitrou
pushed a commit
that referenced
this issue
Feb 8, 2024
…ilder::AppendArraySlice (#39994) ### Rationale for this change Fix the bug in `BinaryViewBuilder::AppendArraySlice` that, when calculating out-of-line data size, the array is wrongly iterated. ### What changes are included in this PR? Fix and UT. ### Are these changes tested? UT included. ### Are there any user-facing changes? No. * Closes: #39976 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…ViewBuilder::AppendArraySlice (apache#39994) ### Rationale for this change Fix the bug in `BinaryViewBuilder::AppendArraySlice` that, when calculating out-of-line data size, the array is wrongly iterated. ### What changes are included in this PR? Fix and UT. ### Are these changes tested? UT included. ### Are there any user-facing changes? No. * Closes: apache#39976 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd
pushed a commit
that referenced
this issue
Feb 20, 2024
…ilder::AppendArraySlice (#39994) ### Rationale for this change Fix the bug in `BinaryViewBuilder::AppendArraySlice` that, when calculating out-of-line data size, the array is wrongly iterated. ### What changes are included in this PR? Fix and UT. ### Are these changes tested? UT included. ### Are there any user-facing changes? No. * Closes: #39976 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
amoeba
added
the
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
label
Feb 27, 2024
zanmato1984
added a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
…ViewBuilder::AppendArraySlice (apache#39994) ### Rationale for this change Fix the bug in `BinaryViewBuilder::AppendArraySlice` that, when calculating out-of-line data size, the array is wrongly iterated. ### What changes are included in this PR? Fix and UT. ### Are these changes tested? UT included. ### Are there any user-facing changes? No. * Closes: apache#39976 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this issue
Mar 8, 2024
…ViewBuilder::AppendArraySlice (apache#39994) ### Rationale for this change Fix the bug in `BinaryViewBuilder::AppendArraySlice` that, when calculating out-of-line data size, the array is wrongly iterated. ### What changes are included in this PR? Fix and UT. ### Are these changes tested? UT included. ### Are there any user-facing changes? No. * Closes: apache#39976 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: C++
Critical Fix
Bugfixes for security vulnerabilities, crashes, or invalid data.
Type: bug
Describe the bug, including details regarding any error messages, version, and platform.
This is a failure that should have been reported by our ASAN check but is somehow prevented by the problem discussed in #39973 . There is a a living demo in https://github.com/zanmato1984/arrow/actions/runs/7752895694/job/21143188221?pr=3#step:6:3370. One can also reproduce this issue in local by:
Component(s)
C++
The text was updated successfully, but these errors were encountered: