[C++][FS][Azure] Implement DeleteFile() for flat-namespace storage accounts
#40074
Comments
felipecrv
changed the title
DeleteFile for flat-namespace storage accountsDeleteFile() for flat-namespace storage accounts
felipecrv
added a commit
that referenced
this issue
Feb 21, 2024
…e storage accounts (#40075) ### Rationale for this change It was not implemented yet. ### What changes are included in this PR? - An implementation of `DeleteFile()` that is specialized to storage accounts that don't have HNS support enabled - This fixes a semantic issue: deleting a file should not delete the parent directory when the file deleted was the last one - Increased test coverage - Fix of a bug in the version that deletes files in HNS-enabled accounts (we shouldn't let `DeleteFile` delete directories even if they are empty) ### Are these changes tested? Yes. Tests were re-written and moved to `TestAzureFileSystemOnAllScenarios`. * Closes: #40074 Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Co-authored-by: jerry.adair <Jerry.Adair@sas.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
|
felipecrv - Have you begun work on this one? |
|
Apologies, I didn't include the link! This is the one I was referring to, the move in the flat-namespace storage accounts: |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
…mespace storage accounts (apache#40075) ### Rationale for this change It was not implemented yet. ### What changes are included in this PR? - An implementation of `DeleteFile()` that is specialized to storage accounts that don't have HNS support enabled - This fixes a semantic issue: deleting a file should not delete the parent directory when the file deleted was the last one - Increased test coverage - Fix of a bug in the version that deletes files in HNS-enabled accounts (we shouldn't let `DeleteFile` delete directories even if they are empty) ### Are these changes tested? Yes. Tests were re-written and moved to `TestAzureFileSystemOnAllScenarios`. * Closes: apache#40074 Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Co-authored-by: jerry.adair <Jerry.Adair@sas.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this issue
Mar 8, 2024
…mespace storage accounts (apache#40075) ### Rationale for this change It was not implemented yet. ### What changes are included in this PR? - An implementation of `DeleteFile()` that is specialized to storage accounts that don't have HNS support enabled - This fixes a semantic issue: deleting a file should not delete the parent directory when the file deleted was the last one - Increased test coverage - Fix of a bug in the version that deletes files in HNS-enabled accounts (we shouldn't let `DeleteFile` delete directories even if they are empty) ### Are these changes tested? Yes. Tests were re-written and moved to `TestAzureFileSystemOnAllScenarios`. * Closes: apache#40074 Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Co-authored-by: jerry.adair <Jerry.Adair@sas.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
AzureFileSystem::DeleteFileis implemented for storage accounts with Hierarchical Namespace Support enabled (GH-38703), but not for storage accounts that can use only the Blobs API and represent directories with empty directory marker blobs.This is a child of GH-18014.
Component(s)
C++
The text was updated successfully, but these errors were encountered: