[C++][CMake] Use arrow/util/config.h.cmake instead of add_definitions() #40221
Comments
kou
added a commit
to kou/arrow
that referenced
this issue
Feb 24, 2024
… add_definitions() It's easy to maintain.
kou
added a commit
to kou/arrow
that referenced
this issue
Feb 24, 2024
… add_definitions() It's easy to maintain.
kou
added a commit
that referenced
this issue
Feb 24, 2024
…efinitions() (#40222) ### Rationale for this change It's easy to maintain. ### What changes are included in this PR? Use `#cmakedefine` in `cpp/src/arrow/util/config.h.cmake` and `#include "arrow/util/config.h"` instead of `add_definition(...)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #40221 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
|
Issue resolved by pull request 40222 |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this issue
Feb 28, 2024
… add_definitions() (apache#40222) ### Rationale for this change It's easy to maintain. ### What changes are included in this PR? Use `#cmakedefine` in `cpp/src/arrow/util/config.h.cmake` and `#include "arrow/util/config.h"` instead of `add_definition(...)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#40221 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this issue
Mar 8, 2024
… add_definitions() (apache#40222) ### Rationale for this change It's easy to maintain. ### What changes are included in this PR? Use `#cmakedefine` in `cpp/src/arrow/util/config.h.cmake` and `#include "arrow/util/config.h"` instead of `add_definition(...)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#40221 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
It's easy to maintain.
add_definitions()is directory scope. So we haveadd_definitions(-DARROW_WITH_ZLIB)incpp/src/arrow/andcpp/src/parquet/Component(s)
C++
The text was updated successfully, but these errors were encountered: