Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][CMake] Improve description why we need to initialize AWS C++ SDK in arrow-s3fs-test #40228

Closed
kou opened this issue Feb 26, 2024 · 1 comment
Closed

[C++][CMake] Improve description why we need to initialize AWS C++ SDK in arrow-s3fs-test #40228

kou opened this issue Feb 26, 2024 · 1 comment
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@kou
Copy link
Member

kou commented Feb 26, 2024

Describe the enhancement requested

It's introduced in #34159 to avoid arrow-s3fs-test crash. But I didn't fully understand why it's happen. Now I understand why it's happen only on Linux. Static linking + private symbols (by version script) are important. Only static linking isn't important.

Component(s)

C++
kou added a commit to kou/arrow that referenced this issue Feb 26, 2024
@kou
apacheGH-40228: [C++][CMake] Improve description why we need to initi…
20f4e9a 
…alize AWS C++ SDK in arrow-s3fs-test
@github-actions github-actions bot mentioned this issue Feb 26, 2024
Merged
kou added a commit that referenced this issue Feb 27, 2024
@kou
GH-40228: [C++][CMake] Improve description why we need to initialize …
2235a7e 
…AWS C++ SDK in arrow-s3fs-test (#40229)

### Rationale for this change

Only static linking isn't important. Static linking + private symbols are important.

### What changes are included in this PR?

Improve comment and macro name.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #40228

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 16.0.0 milestone Feb 27, 2024
@kou
Copy link
Member Author

kou commented Feb 27, 2024

Issue resolved by pull request 40229
#40229

@kou kou closed this as completed Feb 27, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
@kou @zanmato1984
apacheGH-40228: [C++][CMake] Improve description why we need to initi…
3b2ea9c 
…alize AWS C++ SDK in arrow-s3fs-test (apache#40229)

### Rationale for this change

Only static linking isn't important. Static linking + private symbols are important.

### What changes are included in this PR?

Improve comment and macro name.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#40228

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@kou @thisisnic
apacheGH-40228: [C++][CMake] Improve description why we need to initi…
149f5a6 
…alize AWS C++ SDK in arrow-s3fs-test (apache#40229)

### Rationale for this change

Only static linking isn't important. Static linking + private symbols are important.

### What changes are included in this PR?

Improve comment and macro name.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#40228

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
1 participant
@kou