Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][CMake] cpp/src/arrow/util/logging.cc misses glog::glog dependency #40331

Closed
kou opened this issue Mar 4, 2024 · 1 comment
Closed

[C++][CMake] cpp/src/arrow/util/logging.cc misses glog::glog dependency #40331

kou opened this issue Mar 4, 2024 · 1 comment
Assignees
Milestone

Comments

@kou
Copy link
Member

kou commented Mar 4, 2024

Describe the bug, including details regarding any error messages, version, and platform.

This is a problem by #39824.

cpp/src/arrow/util/logging.cc may use glog. So arrow_util OBJECT target(s) must depend on glog::glog.

Component(s)

C++

@kou kou added the Type: bug label Mar 4, 2024
kou added a commit to kou/arrow that referenced this issue Mar 4, 2024
kou added a commit that referenced this issue Mar 4, 2024
#40332)

### Rationale for this change

`cpp/src/arrow/util/logging.cc` may use glog. So `arrow_util` OBJECT target(s) must depend on `glog::glog`.

### What changes are included in this PR?

Add missing `glog::glog` dependency to `${ARROW_UTIL_TARGETS}`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #40331

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 16.0.0 milestone Mar 4, 2024
@kou
Copy link
Member Author

kou commented Mar 4, 2024

Issue resolved by pull request 40332
#40332

@kou kou closed this as completed Mar 4, 2024
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
…ow_util (apache#40332)

### Rationale for this change

`cpp/src/arrow/util/logging.cc` may use glog. So `arrow_util` OBJECT target(s) must depend on `glog::glog`.

### What changes are included in this PR?

Add missing `glog::glog` dependency to `${ARROW_UTIL_TARGETS}`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#40331

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant