Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] arrow/io/compressed_test.cc doesn't including config.h #40621

Closed
mapleFU opened this issue Mar 18, 2024 · 4 comments
Closed

[C++] arrow/io/compressed_test.cc doesn't including config.h #40621

mapleFU opened this issue Mar 18, 2024 · 4 comments
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
16.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Mar 18, 2024

Describe the enhancement requested

arrow/io/compressed_test.cc doesn't including config.h, so testing is not being run

Component(s)

C++
@kou
Copy link
Member

kou commented Mar 18, 2024

Oh... Sorry...

kou added a commit to kou/arrow that referenced this issue Mar 18, 2024
@kou
apacheGH-40621: [C++] Add missing util/config.h in arrow/io/compresse…
90c6ca4 
…d_test.cc
@mapleFU
Copy link
Member Author

mapleFU commented Mar 18, 2024

Besides, we also needs to check benchmarking for that :-)

@github-actions github-actions bot mentioned this issue Mar 18, 2024
Merged
@mapleFU
Copy link
Member Author

mapleFU commented Mar 18, 2024

( I've checked that benchmarking has that )

mapleFU pushed a commit that referenced this issue Mar 18, 2024
@kou
GH-40621: [C++] Add missing util/config.h in arrow/io/compressed_test…
0840151 
….cc (#40625)

### Rationale for this change

This is a follow-up of #40222. We need `#include arrow/util/config.h` for `ARROW_WITH_*`.

### What changes are included in this PR?

Add missing `#include`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #40621

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: mwish <anmmscs_maple@qq.com>
@mapleFU mapleFU added this to the 16.0.0 milestone Mar 18, 2024
@mapleFU
Copy link
Member Author

mapleFU commented Mar 18, 2024

Issue resolved by pull request 40625
#40625

@mapleFU mapleFU closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@kou @mapleFU