Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#][Flight] Add DoExchange initial implementation #40690

Closed
qmmk opened this issue Mar 20, 2024 · 1 comment
Closed

[C#][Flight] Add DoExchange initial implementation #40690

qmmk opened this issue Mar 20, 2024 · 1 comment
Assignees
@qmmk
Labels
Component: C# Component: FlightRPC Type: enhancement
Milestone
16.0.0

Comments

@qmmk
Copy link
Contributor

qmmk commented Mar 20, 2024 •
edited
Loading

Describe the enhancement requested

Add initial implementation for DoExchange method.

PRs and other links:

Component(s)

C#, FlightRPC
@github-actions github-actions bot mentioned this issue Mar 20, 2024
Merged
CurtHagenlocher pushed a commit that referenced this issue Mar 23, 2024
@qmmk
GH-40690: [C#][FlightRPC] Add do_exchange csharp implementation (#40691)
6aa6f85 
### Rationale for this change

This is a draft implementation of DoExchange. A simple usage demo is in FlightTests.cs and TestFlightServer.cs.
I've tried to share the implementation with DoGet/DoPut as much as possible.

### What changes are included in this PR?

- FlightServer.cs and related FlightServerImplementation.cs
- FlightClient.cs with (new) FlightRecordBatchExchangeCall.cs wrapper call.

### Are these changes tested?

Yes, tests are added in FlightTest.cs and TestFlightServer.cs
I've tested locally with the C++ implementation.

### Are there any user-facing changes?

No and the DoExchange documentation is already present

* GitHub Issue: #40690

Lead-authored-by: Marco Malagoli <mmalagoli@board.com>
Co-authored-by: qmmk <47608571+qmmk@users.noreply.github.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
@CurtHagenlocher CurtHagenlocher added this to the 16.0.0 milestone Mar 23, 2024
@CurtHagenlocher
Copy link
Contributor

Issue resolved by pull request 40691
#40691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qmmk qmmk

Labels
Component: C# Component: FlightRPC Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@CurtHagenlocher @qmmk