Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R][CI] test-duckdb.R is failing on several nightly jobs #40702

Closed
raulcd opened this issue Mar 21, 2024 · 3 comments
Closed

[R][CI] test-duckdb.R is failing on several nightly jobs #40702

raulcd opened this issue Mar 21, 2024 · 3 comments

Comments

@raulcd
Copy link
Member

raulcd commented Mar 21, 2024

Describe the bug, including details regarding any error messages, version, and platform.

There are several nightly jobs failing:

With the following error:

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-duckdb.R:286:5'): to_duckdb passing a connection ───────────────
Error in `unclass(unclass(table_four)$lazy_query$x)$table`: $ operator is invalid for atomic vectors

Component(s)

Continuous Integration, R

@raulcd
Copy link
Member Author

raulcd commented Mar 21, 2024

cc @paleolimbot @assignUser

@paleolimbot
Copy link
Member

I think there was a new version of duckdb ~last week (and maybe Posit Package Manager just picked up the update)...it could also be a dplyr or dbplyr update (we use non-public APIs of those to implement the duckdb connection).

thisisnic pushed a commit that referenced this issue Mar 21, 2024
…0710)

### Rationale for this change

Most R CI is failing because of a dbplyr update that updated the internals of the intermediate representation. This was also a problem the last time dbplyr was updated where I believe it was me that hacked the fix of just using the *new* internal structure.

### What changes are included in this PR?

This fix eliminates the use of the dbplyr internals for that test, instead scraping the SQL query for the table name.

### Are these changes tested?

Covered by existing tests

### Are there any user-facing changes?

No
* GitHub Issue: #40702

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic
Copy link
Member

Issue resolved by pull request 40710
#40710

@thisisnic thisisnic added this to the 16.0.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants