Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Need to update README.md #40847

Closed
ericsun2 opened this issue Mar 27, 2024 · 2 comments
Closed

[Go] Need to update README.md #40847

ericsun2 opened this issue Mar 27, 2024 · 2 comments
Assignees
@zeroshade
Labels
Component: Benchmarking Component: C++ Component: Documentation Component: Go Type: bug
Milestone
16.0.0

Comments

@ericsun2
Copy link

ericsun2 commented Mar 27, 2024 •
edited by kou
Loading

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/apache/arrow/tree/main/go#performance has a broken reference to https://github.com/apache/arrow/blob/main/go/arrow/internal/cpu/README.md

Please kindly fix the README.md with the updated reference/link. The SIMD/AVX section is quite useful, especially for the cloud env with the modern Intel/AMD/Graviton CPU types.

Thanks

Component(s)

Benchmarking, C++, Documentation, Go
@kou kou changed the title Golang: Need to update README.md [Go] Need to update README.md Mar 28, 2024
@llama90
Copy link
Contributor

llama90 commented Mar 28, 2024

FYI, This directory(go/arrow/internal/cpu) was deleted in a past commit. It seems that the CPU discovery package used in the Go section has been replaced with the golang.org/x/sys/cpu module.

arrow/go/README.md

Lines 90 to 91 in b270dcd

runtime. See the `cpu` package [README](arrow/internal/cpu/README.md) for a
description of this environment variable.

This might be deleted or mentioned that golang.org/x/sys/cpu is being used.

cc @zeroshade

zeroshade added a commit that referenced this issue Mar 28, 2024
@zeroshade
GH-40847: [Go] update readme
88484e6 
Remove reference to deleted internal package
@github-actions github-actions bot mentioned this issue Mar 28, 2024
Merged
zeroshade added a commit that referenced this issue Mar 28, 2024
@zeroshade
GH-40847: [Go] update readme (#40877)
7d11112 
### Rationale for this change
Remove reference to deleted internal package

* GitHub Issue: #40847

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade
Copy link
Member

Issue resolved by pull request 40877
#40877

@zeroshade zeroshade added this to the 16.0.0 milestone Mar 28, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@zeroshade @tolleybot
apacheGH-40847: [Go] update readme (apache#40877)
4ae79ad 
### Rationale for this change
Remove reference to deleted internal package

* GitHub Issue: apache#40847

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@zeroshade @vibhatha
apacheGH-40847: [Go] update readme (apache#40877)
4b1957d 
### Rationale for this change
Remove reference to deleted internal package

* GitHub Issue: apache#40847

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Benchmarking Component: C++ Component: Documentation Component: Go Type: bug
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
3 participants
@zeroshade @llama90 @ericsun2