Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][FlightRPC] IntervalMonthDayNanoVector should be supported in FlightSQL JDBC Driver #40893

Closed
pgwhalen opened this issue Mar 29, 2024 · 1 comment · Fixed by #40894
Closed

Comments

@pgwhalen
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

I built a FlightSQL server using DataFusion and noticed that using interval math in certain queries returns the newer MonthDayNanoInterval type, which resulted in this UnsupportedOperationException getting thrown when running those queries.

I will follow up with a PR to add support.

Component(s)

FlightRPC, Java

lidavidm pushed a commit that referenced this issue Mar 31, 2024
…ghtSQL JDBC Driver (#40894)

### Rationale for this change

Fixes #40893.

### What changes are included in this PR?

 - Support IntervalMonthDayNanoVector in FlightSQL JDBC Driver
 - Return PeriodDuration as JDBC Object type, because there is no good java.time type for this interval
 - Return an ISO-8601 interval as the stringified version of PeriodDuration
 - Make PeriodDuration implement TemporalAccessor for standardization

### Are these changes tested?

Unit tests have been added that match those for other interval types.  I'm unaware of any other types of tests worth adding to, but I'd be happy to if pointed there.

### Are there any user-facing changes?

The only change users should noticed is that the FlightSQL JDBC Driver can now handle more query responses.
* GitHub Issue: #40893

Authored-by: paul <pgwhalen@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 16.0.0 milestone Mar 31, 2024
@lidavidm
Copy link
Member

Issue resolved by pull request 40894
#40894

tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…in FlightSQL JDBC Driver (apache#40894)

### Rationale for this change

Fixes apache#40893.

### What changes are included in this PR?

 - Support IntervalMonthDayNanoVector in FlightSQL JDBC Driver
 - Return PeriodDuration as JDBC Object type, because there is no good java.time type for this interval
 - Return an ISO-8601 interval as the stringified version of PeriodDuration
 - Make PeriodDuration implement TemporalAccessor for standardization

### Are these changes tested?

Unit tests have been added that match those for other interval types.  I'm unaware of any other types of tests worth adding to, but I'd be happy to if pointed there.

### Are there any user-facing changes?

The only change users should noticed is that the FlightSQL JDBC Driver can now handle more query responses.
* GitHub Issue: apache#40893

Authored-by: paul <pgwhalen@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…in FlightSQL JDBC Driver (apache#40894)

### Rationale for this change

Fixes apache#40893.

### What changes are included in this PR?

 - Support IntervalMonthDayNanoVector in FlightSQL JDBC Driver
 - Return PeriodDuration as JDBC Object type, because there is no good java.time type for this interval
 - Return an ISO-8601 interval as the stringified version of PeriodDuration
 - Make PeriodDuration implement TemporalAccessor for standardization

### Are these changes tested?

Unit tests have been added that match those for other interval types.  I'm unaware of any other types of tests worth adding to, but I'd be happy to if pointed there.

### Are there any user-facing changes?

The only change users should noticed is that the FlightSQL JDBC Driver can now handle more query responses.
* GitHub Issue: apache#40893

Authored-by: paul <pgwhalen@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants