[Java] Implement a function to retrieve reference buffers in StringView #40930
Comments
vibhatha
changed the title
lidavidm
pushed a commit
that referenced
this issue
May 24, 2024
…n StringView (#41796) ### Rationale for this change This PR includes a minor changes to the `getBuffers` method in `BaseVariableWidthViewVector`. ### What changes are included in this PR? Previously the fixed buffers were the only ones returned from this method because of lack of clarity in the initial implementation stage. In this PR, it includes the variadic buffers to the result. A test case has also being added. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: #40930 Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
|
Issue resolved by pull request 41796 |
vibhatha
added a commit
to vibhatha/arrow
that referenced
this issue
May 25, 2024
…fers in StringView (apache#41796) ### Rationale for this change This PR includes a minor changes to the `getBuffers` method in `BaseVariableWidthViewVector`. ### What changes are included in this PR? Previously the fixed buffers were the only ones returned from this method because of lack of clarity in the initial implementation stage. In this PR, it includes the variadic buffers to the result. A test case has also being added. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#40930 Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
At the moment in the StringView implementation,
public ArrowBuf[] getBuffers(boolean clear)function only returns theoffset, validity and valuebuffers. But for recreating views entirely and support related features it would be better to introduce additional function or improve the existing function to return the view buffers.Component(s)
Java
The text was updated successfully, but these errors were encountered: