Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Enhance the copyFrom* functionality in StringView #40933

Closed
vibhatha opened this issue Apr 2, 2024 · 1 comment
Closed

[Java] Enhance the copyFrom* functionality in StringView #40933

vibhatha opened this issue Apr 2, 2024 · 1 comment
Assignees
@vibhatha
Labels
Component: Java Type: enhancement
Milestone
17.0.0

Comments

@vibhatha
Copy link
Collaborator

vibhatha commented Apr 2, 2024

Describe the enhancement requested

At the moment in the StringView implementation, doesn't support a fully copy functionality including the view buffers, it only supports the inline views. This functionality needs to be extended to support views.

Component(s)

Java
@vibhatha vibhatha self-assigned this Apr 29, 2024
@github-actions github-actions bot mentioned this issue May 21, 2024
Merged
lidavidm pushed a commit that referenced this issue May 25, 2024
@vibhatha
GH-40933: [Java] Enhance the copyFrom* functionality in StringView (#…
54dfb82 
…41752)

### Rationale for this change

Initial implementation of StringView doesn't contain `copy` functionality. This PR adds that feature. 

### What changes are included in this PR?

This PR adds `copyFrom` and `copyFromSafe` functions to `BaseVariableWidthViewVector`. 

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: #40933

Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 17.0.0 milestone May 25, 2024
@lidavidm
Copy link
Member

Issue resolved by pull request 41752
#41752

vibhatha added a commit to vibhatha/arrow that referenced this issue May 25, 2024
@vibhatha
apacheGH-40933: [Java] Enhance the copyFrom* functionality in StringV…
715c0c6 
…iew (apache#41752)

### Rationale for this change

Initial implementation of StringView doesn't contain `copy` functionality. This PR adds that feature. 

### What changes are included in this PR?

This PR adds `copyFrom` and `copyFromSafe` functions to `BaseVariableWidthViewVector`. 

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#40933

Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhatha vibhatha

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@lidavidm @vibhatha