Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] ListView pandas conversion tests are failing when comparing None vs np.nan #41039

Closed
danepitkin opened this issue Apr 5, 2024 · 1 comment

Comments

@danepitkin
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

The upstream development branches of pandas and numpy are failing in pyarrow on tests test_list_view_to_pandas_with_null_values and test_list_view_to_pandas_multiple_chunks. See https://github.com/ursacomputing/crossbow/actions/runs/8547330438/job/23419298897.

Component(s)

Python

@danepitkin danepitkin added this to the 16.0.0 milestone Apr 5, 2024
AlenkaF pushed a commit that referenced this issue Apr 5, 2024
… None (#41040)

### Rationale for this change

ListView pandas conversion tests are failing in upstream development branches of pandas/numpy.

### What changes are included in this PR?

* Use np.nan instead of None when comparing with an expected Pandas Series.

### Are these changes tested?

Yes, unit tests updated.

### Are there any user-facing changes?

No.
* GitHub Issue: #41039

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
@AlenkaF
Copy link
Member

AlenkaF commented Apr 5, 2024

Issue resolved by pull request 41040
#41040

@AlenkaF AlenkaF closed this as completed Apr 5, 2024
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…ead of None (apache#41040)

### Rationale for this change

ListView pandas conversion tests are failing in upstream development branches of pandas/numpy.

### What changes are included in this PR?

* Use np.nan instead of None when comparing with an expected Pandas Series.

### Are these changes tested?

Yes, unit tests updated.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41039

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…ead of None (apache#41040)

### Rationale for this change

ListView pandas conversion tests are failing in upstream development branches of pandas/numpy.

### What changes are included in this PR?

* Use np.nan instead of None when comparing with an expected Pandas Series.

### Are these changes tested?

Yes, unit tests updated.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41039

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants