Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Python] test_make_write_options_error failing on crossbow build #41043

Closed
AlenkaF opened this issue Apr 5, 2024 · 1 comment
Closed

[CI][Python] test_make_write_options_error failing on crossbow build #41043

AlenkaF opened this issue Apr 5, 2024 · 1 comment
Assignees
@AlenkaF
Labels
Component: Continuous Integration Component: Python
Milestone
16.0.0

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Apr 5, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

test_dataset.py:test_make_write_options_error is failing on conda-python-cython2 build with

________________________ test_make_write_options_error _________________________

    def test_make_write_options_error():
        # GH-39440
        msg = ("make_write_options\\(\\) should be called on an "
               "instance of ParquetFileFormat")
        with pytest.raises(TypeError, match=msg):
>           pa.dataset.ParquetFileFormat.make_write_options(43)
E           TypeError: descriptor 'make_write_options' for 'pyarrow._dataset_parquet.ParquetFileFormat' objects doesn't apply to a 'int' object

opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/test_dataset.py:5640: TypeError

During handling of the above exception, another exception occurred:

    def test_make_write_options_error():
        # GH-39440
        msg = ("make_write_options\\(\\) should be called on an "
               "instance of ParquetFileFormat")
>       with pytest.raises(TypeError, match=msg):
E       AssertionError: Regex pattern did not match.
E        Regex: 'make_write_options\\(\\) should be called on an instance of ParquetFileFormat'
E        Input: "descriptor 'make_write_options' for 'pyarrow._dataset_parquet.ParquetFileFormat' objects doesn't apply to a 'int' object"

opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/test_dataset.py:5639: AssertionError

See: https://github.com/ursacomputing/crossbow/actions/runs/8573647554/job/23498752189.

The PR causing this failure: #40976

Component(s)

Continuous Integration, Python
@AlenkaF AlenkaF self-assigned this Apr 5, 2024
@AlenkaF AlenkaF mentioned this issue Apr 5, 2024
Merged
@AlenkaF AlenkaF changed the title [CI][Python] test_make_write_options_error failing on CI [CI][Python] test_make_write_options_error failing on crossbow build Apr 5, 2024
@github-actions github-actions bot mentioned this issue Apr 8, 2024
Merged
@AlenkaF AlenkaF added this to the 16.0.0 milestone Apr 8, 2024
raulcd pushed a commit that referenced this issue Apr 10, 2024
@AlenkaF
GH-41043: [CI][Python] check message in test_make_write_options_error…
376a271 
… for Cython 2 (#41059)

### Rationale for this change

`test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in #40976.

### What changes are included in this PR?

Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in #40976.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41043

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@raulcd
Copy link
Member

raulcd commented Apr 10, 2024

Issue resolved by pull request 41059
#41059

@raulcd raulcd closed this as completed Apr 10, 2024
raulcd pushed a commit that referenced this issue Apr 10, 2024
@AlenkaF @raulcd
GH-41043: [CI][Python] check message in test_make_write_options_error…
e138bdc 
… for Cython 2 (#41059)

### Rationale for this change

`test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in #40976.

### What changes are included in this PR?

Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in #40976.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41043

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Apr 15, 2024
@AlenkaF @vibhatha
apacheGH-41043: [CI][Python] check message in test_make_write_options…
2ae24ea 
…_error for Cython 2 (apache#41059)

### Rationale for this change

`test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in apache#40976.

### What changes are included in this PR?

Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in apache#40976.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41043

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@AlenkaF @tolleybot
apacheGH-41043: [CI][Python] check message in test_make_write_options…
ed5a0b4 
…_error for Cython 2 (apache#41059)

### Rationale for this change

`test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in apache#40976.

### What changes are included in this PR?

Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in apache#40976.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41043

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
@AlenkaF @tolleybot
apacheGH-41043: [CI][Python] check message in test_make_write_options…
61c4296 
…_error for Cython 2 (apache#41059)

### Rationale for this change

`test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in apache#40976.

### What changes are included in this PR?

Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in apache#40976.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41043

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@AlenkaF @rok
apacheGH-41043: [CI][Python] check message in test_make_write_options…
15dd6b9 
…_error for Cython 2 (apache#41059)

### Rationale for this change

`test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in apache#40976.

### What changes are included in this PR?

Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in apache#40976.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41043

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@AlenkaF @rok
apacheGH-41043: [CI][Python] check message in test_make_write_options…
8b71b49 
…_error for Cython 2 (apache#41059)

### Rationale for this change

`test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in apache#40976.

### What changes are included in this PR?

Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in apache#40976.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41043

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@AlenkaF @vibhatha
apacheGH-41043: [CI][Python] check message in test_make_write_options…
273a5ae 
…_error for Cython 2 (apache#41059)

### Rationale for this change

`test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in apache#40976.

### What changes are included in this PR?

Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in apache#40976.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41043

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: Continuous Integration Component: Python
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@raulcd @AlenkaF