Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Stop defining ARROW_TEST_MEMCHECK in config.h.cmake #41176

Closed
kou opened this issue Apr 12, 2024 · 1 comment
Closed

[C++] Stop defining ARROW_TEST_MEMCHECK in config.h.cmake #41176

kou opened this issue Apr 12, 2024 · 1 comment
Assignees
@kou
Labels
Component: C++ Type: bug
Milestone
16.0.0

Comments

@kou
Copy link
Member

kou commented Apr 12, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

We already have the ARROW_VALGRIND macro for Valgrind. We don't need to define a new macro for Valgrind.

See also: #41163 (comment)

Component(s)

C++
@kou kou added the Type: bug label Apr 12, 2024
@kou kou added this to the 16.0.0 milestone Apr 12, 2024
kou added a commit to kou/arrow that referenced this issue Apr 12, 2024
@kou
apacheGH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.c…
6fffa3a 
…make
@github-actions github-actions bot mentioned this issue Apr 12, 2024
Merged
@kou kou mentioned this issue Apr 12, 2024
Merged
kou added a commit that referenced this issue Apr 13, 2024
@kou
GH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.cmake (#…
2979d69 
…41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41176

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member Author

kou commented Apr 13, 2024

Issue resolved by pull request 41177
#41177

@kou kou closed this as completed Apr 13, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Apr 15, 2024
@kou @vibhatha
apacheGH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.c…
a6d1778 
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
raulcd pushed a commit that referenced this issue Apr 15, 2024
@kou @raulcd
GH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.cmake (#…
8c625d7 
…41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #41176

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@kou @tolleybot
apacheGH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.c…
f8bae20 
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
@kou @tolleybot
apacheGH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.c…
0ba37ab 
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@kou @rok
apacheGH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.c…
515818c 
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@kou @rok
apacheGH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.c…
c6f78d9 
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@kou @vibhatha
apacheGH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.c…
ebeb789 
…make (apache#41177)

### Rationale for this change

We already have `ARROW_VALGRIND`.

### What changes are included in this PR?

Remove redundant macro.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41176

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
1 participant
@kou