Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Can't read date64 value from CSV while write is supported #41594

Closed
candiduslynx opened this issue May 8, 2024 · 3 comments
Closed

[Go] Can't read date64 value from CSV while write is supported #41594

candiduslynx opened this issue May 8, 2024 · 3 comments
Assignees
@candiduslynx
Labels
Component: Go Type: bug
Milestone
16.1.0

Comments

@candiduslynx
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

on v16 can write date64 column, but can't read it

Component(s)

Go
@candiduslynx
Copy link
Contributor Author

take

@candiduslynx candiduslynx mentioned this issue May 8, 2024
Merged
@davlee1972
Copy link

Can add this one to the list..
#41488

zeroshade pushed a commit that referenced this issue May 8, 2024
@candiduslynx
GH-41594: [Go] Support reading date64 type & properly validate list…
5252c6c 
…-like types (#41595)

This PR includes 2 fixes:
1. support reading `date64` columns (as write is supported)
2. properly validate list-like data types (list of unsupported is unsupported)

### Rationale for this change

See #41594

### What changes are included in this PR?

1. Added `date64` reading & conversion funcs similar to `date32`
2. Refactored date type validation

### Are these changes tested?

a55cd53

### Are there any user-facing changes?

No.

* GitHub Issue: #41594

Authored-by: candiduslynx <candiduslynx@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade
Copy link
Member

Issue resolved by pull request 41595
#41595

@zeroshade zeroshade added this to the 17.0.0 milestone May 8, 2024
@raulcd raulcd modified the milestones: 17.0.0, 16.1.0 May 9, 2024
raulcd pushed a commit that referenced this issue May 9, 2024
@candiduslynx @raulcd
GH-41594: [Go] Support reading date64 type & properly validate list…
5874287 
…-like types (#41595)

This PR includes 2 fixes:
1. support reading `date64` columns (as write is supported)
2. properly validate list-like data types (list of unsupported is unsupported)

### Rationale for this change

See #41594

### What changes are included in this PR?

1. Added `date64` reading & conversion funcs similar to `date32`
2. Refactored date type validation

### Are these changes tested?

a55cd53

### Are there any user-facing changes?

No.

* GitHub Issue: #41594

Authored-by: candiduslynx <candiduslynx@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@candiduslynx @vibhatha
apacheGH-41594: [Go] Support reading date64 type & properly validat…
ee4fb91 
…e list-like types (apache#41595)

This PR includes 2 fixes:
1. support reading `date64` columns (as write is supported)
2. properly validate list-like data types (list of unsupported is unsupported)

### Rationale for this change

See apache#41594

### What changes are included in this PR?

1. Added `date64` reading & conversion funcs similar to `date32`
2. Refactored date type validation

### Are these changes tested?

a55cd53

### Are there any user-facing changes?

No.

* GitHub Issue: apache#41594

Authored-by: candiduslynx <candiduslynx@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@candiduslynx candiduslynx

Labels
Component: Go Type: bug
Projects
None yet
Milestone
16.1.0
Development

No branches or pull requests
4 participants
@zeroshade @raulcd @candiduslynx @davlee1972