GH-40930: [Java] Implement a function to retrieve reference buffers in StringView #41796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't expect this change to be very trivial when I created the issue while working on the StringView core PR. Am I missing anything here? cc @lidavidm |
lidavidm
approved these changes
May 24, 2024
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 8a76082. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 54 possible false positives for unstable benchmarks that are known to sometimes produce them. |
vibhatha
added a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…fers in StringView (apache#41796) ### Rationale for this change This PR includes a minor changes to the `getBuffers` method in `BaseVariableWidthViewVector`. ### What changes are included in this PR? Previously the fixed buffers were the only ones returned from this method because of lack of clarity in the initial implementation stage. In this PR, it includes the variadic buffers to the result. A test case has also being added. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#40930 Authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR includes a minor changes to the
getBuffersmethod inBaseVariableWidthViewVector.What changes are included in this PR?
Previously the fixed buffers were the only ones returned from this method because of lack of clarity in the initial implementation stage. In this PR, it includes the variadic buffers to the result. A test case has also being added.
Are these changes tested?
Yes
Are there any user-facing changes?
No