Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-12384: [JS] Use let/const and clean up eslint rules #10030

Closed
wants to merge 3 commits into from
Closed

ARROW-12384: [JS] Use let/const and clean up eslint rules #10030

wants to merge 3 commits into from

Conversation

domoritz
Copy link
Member

No description provided.

@domoritz domoritz changed the title ARROW-12383: [JS] Use let/const ARROW-12383: [JS] Use let/const and clean up eslint rules Apr 14, 2021
@domoritz domoritz marked this pull request as ready for review April 14, 2021 16:46
@kou
Copy link
Member

kou commented Apr 14, 2021

CI is green: https://github.com/domoritz/arrow/actions?query=branch%3Afix-style++

@kou kou changed the title ARROW-12383: [JS] Use let/const and clean up eslint rules ARROW-12384: [JS] Use let/const and clean up eslint rules Apr 14, 2021
@kou kou closed this in ccdbbe3 Apr 14, 2021
@domoritz domoritz deleted the fix-style branch April 14, 2021 19:55
Dandandan pushed a commit to Dandandan/arrow that referenced this pull request Apr 14, 2021
@domoritz @Dandandan
ARROW-12384: [JS] Use let/const and clean up eslint rules
7fb94b8 
Closes apache#10030 from domoritz/fix-style

Authored-by: Dominik Moritz <domoritz@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-12383

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-12384

GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
@domoritz @GeorgeAp
ARROW-12384: [JS] Use let/const and clean up eslint rules
2951e84 
Closes apache#10030 from domoritz/fix-style

Authored-by: Dominik Moritz <domoritz@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
@domoritz @michalursa
ARROW-12384: [JS] Use let/const and clean up eslint rules
325d24f 
Closes apache#10030 from domoritz/fix-style

Authored-by: Dominik Moritz <domoritz@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
@domoritz @michalursa
ARROW-12384: [JS] Use let/const and clean up eslint rules
079bce5 
Closes apache#10030 from domoritz/fix-style

Authored-by: Dominik Moritz <domoritz@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This was referenced Apr 15, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees
No one assigned
Labels
Component: JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@domoritz @kou @trxcllnt