Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-12435: [Rust][DataFusion] Remove unnecessary references to namespace in executor #10084

Closed
wants to merge 1 commit into from
Closed

ARROW-12435: [Rust][DataFusion] Remove unnecessary references to namespace in executor #10084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion rust/ballista/rust/executor/examples/example_executor_config.toml
View file
Open in desktop
Expand Up @@ -18,5 +18,4 @@
# the default configuration location is "/etc/ballista/scheduler.toml"
# if you include a specifc conf file using "--config-file = my_config_file.toml"
# then that file will override environment variables, but not command line arguments
namespace = "my_name_space"
bind_host = "1.2.3.4"
7 changes: 0 additions & 7 deletions rust/ballista/rust/executor/executor_config_spec.toml
View file
Open in desktop
Expand Up @@ -24,13 +24,6 @@ conf_file_param = "config_file"
name = "version"
doc = "Print version of this executable"

[[param]]
abbr = "n"
name = "namespace"
type = "String"
doc = "Namespace for the ballista cluster that this executor will join. yippee"
default = "std::string::String::from(\"ballista\")"

[[param]]
name = "scheduler_host"
type = "String"
Expand Down
3 changes: 1 addition & 2 deletions rust/ballista/rust/executor/src/main.rs
View file
Open in desktop
Expand Up @@ -70,7 +70,6 @@ async fn main() -> Result<()> {
std::process::exit(0);
}

let namespace = opt.namespace;
let external_host = opt.external_host;
let bind_host = opt.bind_host;
let port = opt.port;
Expand Down Expand Up @@ -110,7 +109,7 @@ async fn main() -> Result<()> {
let client = StandaloneClient::try_new_temporary()
.context("Could not create standalone config backend")?;
let server =
SchedulerGrpcServer::new(SchedulerServer::new(Arc::new(client), namespace));
SchedulerGrpcServer::new(SchedulerServer::new(Arc::new(client), "ballista".to_owned()));
let addr = format!("{}:{}", bind_host, scheduler_port);
let addr = addr
.parse()
Expand Down