Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-12595: [C++][Gandiva] Implement TO_HEX([binary] field), HEX, UNHEX and FROM_HEX([string]field] functions #10195

Closed
wants to merge 1 commit into from
Closed

ARROW-12595: [C++][Gandiva] Implement TO_HEX([binary] field), HEX, UNHEX and FROM_HEX([string]field] functions #10195

wants to merge 1 commit into from

Conversation

anthonylouisbsb
Copy link
Contributor

@anthonylouisbsb anthonylouisbsb commented Apr 29, 2021 •
edited

Functions that are responsible to convert binary to hexadecimal string representations.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-12595

projjal
projjal reviewed Apr 29, 2021
View reviewed changes
cpp/src/gandiva/precompiled/string_ops.cc Outdated Show resolved Hide resolved
cpp/src/gandiva/precompiled/string_ops.cc Show resolved Hide resolved
cpp/src/gandiva/precompiled/string_ops.cc Show resolved Hide resolved
cpp/src/gandiva/precompiled/string_ops_test.cc Outdated Show resolved Hide resolved
@anthonylouisbsb anthonylouisbsb changed the title ARROW-12595: [C++][Gandiva] Implement TO_HEX([binary] field) function ARROW-12595: [C++][Gandiva] Implement TO_HEX([binary] field) and FROM_HEX([string]field] functions Apr 29, 2021
@anthonylouisbsb
Copy link
Contributor Author

@projjal In this PR was added the functions related to the FROM_HEX too.

@anthonylouisbsb anthonylouisbsb force-pushed the feature/add-to-hex branch 6 times, most recently from b3cc681 to 5b8d351 Compare May 5, 2021 18:45
@anthonylouisbsb anthonylouisbsb force-pushed the feature/add-to-hex branch 4 times, most recently from 9afa32c to 90ef05d Compare May 10, 2021 13:59
projjal
projjal reviewed May 12, 2021
View reviewed changes
cpp/src/gandiva/function_registry_string.cc Outdated Show resolved Hide resolved
cpp/src/gandiva/precompiled/string_ops.cc Outdated Show resolved Hide resolved
cpp/src/gandiva/precompiled/string_ops.cc Show resolved Hide resolved
@anthonylouisbsb anthonylouisbsb force-pushed the feature/add-to-hex branch 2 times, most recently from 73dbdff to 2141397 Compare June 1, 2021 20:13
@praveenbingo
Copy link
Contributor

@projjal needs rebase

@anthonylouisbsb
Copy link
Contributor Author

@praveenbingo the rebase was applied!

@anthonylouisbsb anthonylouisbsb changed the title ARROW-12595: [C++][Gandiva] Implement TO_HEX([binary] field) and FROM_HEX([string]field] functions ARROW-12595: [C++][Gandiva] Implement TO_HEX([binary] field), HEX, UNHEX and FROM_HEX([string]field] functions Jun 11, 2021
@anthonylouisbsb
Copy link
Contributor Author

@projjal The functions related to HEX and UNHEX were added inside this PR too, so I think you need to review the PR again.

@anthonylouisbsb
Copy link
Contributor Author

@jvictorhuguenin the last two commits started to break some builds, could you check it?

@anthonylouisbsb
Copy link
Contributor Author

anthonylouisbsb commented Jun 23, 2021 •
edited

@jpedroantunes please, after @jvictorhuguenin applies the corrections, could you review it, please?

@anthonylouisbsb
Copy link
Contributor Author

We are still facing some problems with the formatting methods, apparently, some macros are not working fine in some environments.

@jvictorhuguenin jvictorhuguenin force-pushed the feature/add-to-hex branch 2 times, most recently from a0674af to 3f908ef Compare July 15, 2021 15:28
@pravindra pravindra closed this in 6704cdf Nov 24, 2021
@ursabot
Copy link

ursabot commented Nov 24, 2021 •
edited

Benchmark runs are scheduled for baseline = 587ce1d and contender = 6704cdf. 6704cdf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.31% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@anthonylouisbsb anthonylouisbsb deleted the feature/add-to-hex branch November 24, 2021 13:57
PHILO-HE added a commit to PHILO-HE/arrow that referenced this pull request Jun 13, 2022
@PHILO-HE
Port the code from apache#10195
c294a8b
@PHILO-HE PHILO-HE mentioned this pull request Jun 13, 2022
Merged
zhouyuan pushed a commit to oap-project/arrow that referenced this pull request Jun 14, 2022
@PHILO-HE
Port the code from apache#10195 (#116)
2cdbdcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@projjal projjal projjal approved these changes

@jvictorhuguenin jvictorhuguenin jvictorhuguenin approved these changes

Assignees
No one assigned
Labels
Component: C++ - Gandiva Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anthonylouisbsb @praveenbingo @ursabot @projjal @jvictorhuguenin