ARROW-12653: [Archery] allow me to add a comment to crossbow requests #10247
Conversation
|
@github-actions autotune |
| @@ -156,6 +156,7 @@ def handler(command, **kwargs): | |||
|
|
|||
| @pytest.mark.parametrize(('command', 'reaction'), [ | |||
| ('@ursabot build', '+1'), | |||
| ('@ursabot build\nwith a comment', '+1'), | |||
There was a problem hiding this comment.
Thanks Jon for working on this!
Could you please add a test case with additional content preceding the mention?
There was a problem hiding this comment.
Absolutely, I wasn't 100% certain this was the appropriate place to test this — so if it's not let me know.
Also, I expect that test to fail (and respond a -1), though we could probably add support for it if we wanted.
There was a problem hiding this comment.
Turns out that it is a no-op, just like other examples where the @ mention is not first.
There was a problem hiding this comment.
@jonkeane thanks for adding a test case!
We should probably add support for @ mention anywhere in the comment by splitting the lines first.
Could you please create a follow-up jira for this use case (or directly implement it :) in this PR)?
There was a problem hiding this comment.
I made ARROW-12720 I started thinking about doing that splitting, but I'm not totally sure it's a good idea to allow the command to be anywhere (or anywhere at the beginning of a newline). The current code requires that the comment start with the mention which wasn't changed in this PR. At the very least we should discuss/decide what the boundaries ought to be there, which we can do on that ticket before changing that.
Closes apache#10247 from jonkeane/ARROW-12653 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
No description provided.