ARROW-12668: [C++][Dataset] Fix segfault in CountRows #10259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
approved these changes
May 6, 2021
Yes - the test case, with the old code, would cause a use-after-free (since the callback in CountRows would run and try to append to a vector on the stack which doesn't exist anymore). I decided I couldn't capture the original failure effectively in a unit test (two callbacks run concurrently and interleave their calls to push_back) but both are symptoms of the same thing (don't take shared state by reference and then try to use it concurrently!). |
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
The code was obviously incorrect before. This change avoids 1) capturing a variable by reference and 2) mutating a non-thread-safe variable concurrently. Closes apache#10259 from lidavidm/arrow-12668 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was obviously incorrect before. This change avoids 1) capturing a variable by reference and 2) mutating a non-thread-safe variable concurrently.