ARROW-12760: [C++][Python][R] Allow setting I/O thread pool size #10316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
force-pushed
the
arrow-12760
branch
2 times, most recently
from
4485515
to
4e4fc31
Compare
python/pyarrow/io.pxi
Outdated
|
|
||
|
|
||
| def set_io_thread_count(int count): | ||
| """Set the number of threads to use for I/O operations.""" |
There was a problem hiding this comment.
Maybe can add a "See also" reference to set_cpu_count ?
There was a problem hiding this comment.
Done, I cross-referenced the two pairs of functions.
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
This adds functions to change the pool size at runtime, but doesn't adjust the default size of 8. Closes apache#10316 from lidavidm/arrow-12760 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
jonkeane
pushed a commit
that referenced
this pull request
Mar 18, 2022
As noted in ARROW-15929, we have code referring to the wrong thread pool (i.e., `arrow::io_thread_count()` and `arrow::set_io_thread_count()` are actually setting the number of cores used instead of the actual thread count). This appears to have been an inadvertent addition changed in ARROW-12760 (#10316). ``` r # remotes::install_github("apache/arrow/r") library(arrow, warn.conflicts = FALSE) cpu_count() #> [1] 8 set_io_thread_count(4) cpu_count() #> [1] 4 ``` This PR switches that so that we're referring to the correct thread pool: ``` r # remotes::install_github("paleolimbot/arrow/r@r-thread-io-pool-count") library(arrow, warn.conflicts = FALSE) cpu_count() #> [1] 8 set_io_thread_count(4) cpu_count() #> [1] 8 io_thread_count() #> [1] 4 ``` Closes #12633 from paleolimbot/r-thread-io-pool-count Authored-by: Dewey Dunnington <dewey@fishandwhistle.net> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functions to change the pool size at runtime, but doesn't adjust the default size of 8.