ARROW-12619: [Python] pyarrow sdist should not require git #10342
Conversation
… source distribution
|
@github-actions crossbow submit python-sdist wheel-* Still need to verify this locally. |
|
Revision: 4964100 Submitted crossbow builds: ursacomputing/crossbow @ actions-414
|
|
I'm updating the sdist build to check the tarball without git installed. |
|
@github-actions crossbow submit python-sdist This should test the produced source tarball in a git-less environment. |
|
Revision: c423b96 Submitted crossbow builds: ursacomputing/crossbow @ actions-416
|
| if [ -n "${PYARROW_VERSION:-}" ]; then | ||
| sdist="${arrow_dir}/python/dist/pyarrow-${PYARROW_VERSION}.tar.gz" | ||
| else | ||
| sdist=$(ls "${arrow_dir}/python/dist/pyarrow-*.tar.gz" | sort -r | head -n1) | ||
| sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1) |
There was a problem hiding this comment.
very minor nit: you could keep the quoting around just ${arrow_dir}
There was a problem hiding this comment.
Interestingly it didn't pick up the tarball with the quotes, which I wouldn't have expected either.
There was a problem hiding this comment.
Creating arrow_ubuntu-python-sdist-test_run ... done
root@202aa2bdd8d0:/# ls "/arrow/python/dist/pyarrow-*.tar.gz"
ls: cannot access '/arrow/python/dist/pyarrow-*.tar.gz': No such file or directory
root@202aa2bdd8d0:/# ls /arrow/python/dist/pyarrow-*.tar.gz
/arrow/python/dist/pyarrow-5.0.0.dev866+g49641009e.d20210517.tar.gz
root@202aa2bdd8d0:/#There was a problem hiding this comment.
That is expected, but ls "${arrow_dir}"/python/dist/pyarrow-*.tar.gz doesn't work? e.g.
$ export arrow_dir=/tmp/foo
$ touch /tmp/foo/pyarrow-5.0.0.tar.gz
$ ls "${arrow_dir}"/pyarrow-*.tar.gz
/tmp/foo/pyarrow-5.0.0.tar.gz
but either way this is a very minor nit, just if you wanted to be extra-defensive.
There was a problem hiding this comment.
$arrow_dir is going to be /arrow :)
|
The macOS wheel builds are failing due to network timeout. |
There is a fallback_version configuration option for setuptools_scm which we don't use: https://github.com/pypa/setuptools_scm#configuration-parameters Although this setting seems to have issues according to pypa/setuptools_scm#549 We already have a workaround in setup.py for the functionality of the fallback_version option, but it is disabled for the case of sdist: https://github.com/apache/arrow/blob/master/python/setup.py#L529 Closes #10342 from kszucs/ARROW-12619 Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
There is a fallback_version configuration option for setuptools_scm which we don't use: https://github.com/pypa/setuptools_scm#configuration-parameters Although this setting seems to have issues according to pypa/setuptools_scm#549 We already have a workaround in setup.py for the functionality of the fallback_version option, but it is disabled for the case of sdist: https://github.com/apache/arrow/blob/master/python/setup.py#L529 Closes apache#10342 from kszucs/ARROW-12619 Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
There is a fallback_version configuration option for setuptools_scm which we don't use: https://github.com/pypa/setuptools_scm#configuration-parameters
Although this setting seems to have issues according to pypa/setuptools_scm#549
We already have a workaround in setup.py for the functionality of the fallback_version option, but it is disabled for the case of sdist: https://github.com/apache/arrow/blob/master/python/setup.py#L529