Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-11926: [R] Add ucrt64 binaries and fix CI #10372

Closed
wants to merge 3 commits into from
Closed

ARROW-11926: [R] Add ucrt64 binaries and fix CI #10372

wants to merge 3 commits into from

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented May 21, 2021

The R project is experimenting with a new ucrt toolchain. This prepares us by adding ucrt64 binaries to the windows bundle.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@jeroen jeroen changed the title R: also build ucrt64 binaries ARROW-11926: also build ucrt64 binaries May 21, 2021
@github-actions
Copy link

@jeroen jeroen changed the title ARROW-11926: also build ucrt64 binaries ARROW-11926: [R] build ucrt64 binaries May 21, 2021
@jeroen jeroen marked this pull request as ready for review May 21, 2021 17:41
@jeroen jeroen changed the title ARROW-11926: [R] build ucrt64 binaries ARROW-11926: [R] Add ucrt64 binaries and fix CI May 22, 2021
@nealrichardson
Copy link
Member

Thanks @jeroen. Do you have a pointer to how to test the UCRT build?

@jeroen
Copy link
Contributor Author

jeroen commented May 25, 2021

You can use the ucrt build of R: https://github.com/r-windows/docs/blob/master/ucrt.md#readme
But this is pretty experimental perhaps you don't need to automate that part yet.

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will delete these commented out lines and then merge

ci/scripts/r_windows_build.sh Outdated Show resolved Hide resolved
ci/scripts/r_windows_build.sh Outdated Show resolved Hide resolved
@jeroen jeroen deleted the test-ucrt branch May 25, 2021 22:14
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
The R project is experimenting with a new ucrt toolchain. This prepares us by adding ucrt64 binaries to the windows bundle.

Closes apache#10372 from jeroen/test-ucrt

Lead-authored-by: Jeroen Ooms <jeroenooms@gmail.com>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants