ARROW-12858: [C++][Gandiva] Add isNull, isTrue, isFalse, isNotTrue, IsNotFalse and NVL functions on Gandiva #10385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projjal
reviewed
May 26, 2021
rodrigojdebem
force-pushed
the
feature/implement-new-true-false-null
branch
from
a0e0efd
to
b0adc47
Compare
rodrigojdebem
changed the title
projjal
reviewed
Jun 6, 2021
| @@ -84,6 +84,17 @@ std::vector<NativeFunction> GetMathOpsFunctionRegistry() { | |||
| BINARY_GENERIC_SAFE_NULL_IF_NULL(truncate, {"trunc"}, decimal128, int32, | |||
| decimal128), | |||
|
|
|||
| NativeFunction("nvl", {}, DataTypeVector{int32(), int32()}, int32(), | |||
There was a problem hiding this comment.
nit: can use an existing macro for this
|
|
||
| NUMERIC_BOOL_DATE_FUNCTION(NVL) | ||
|
|
||
| #undef VALIDITY_OP |
jpedroantunes
force-pushed
the
feature/implement-new-true-false-null
branch
from
176ba05
to
4fc2edd
Compare
anthonylouisbsb
force-pushed
the
feature/implement-new-true-false-null
branch
from
4fc2edd
to
d711109
Compare
projjal
approved these changes
Jul 13, 2021
|
@projjal Needs a rebase. |
jpedroantunes
force-pushed
the
feature/implement-new-true-false-null
branch
from
d711109
to
5a87f22
Compare
|
@anthonylouisbsb @jvictorhuguenin Can you rebase |
|
@projjal I will do it |
anthonylouisbsb
force-pushed
the
feature/implement-new-true-false-null
branch
3 times, most recently
from
bd3dbe6
to
1061e03
Compare
|
@anthonylouisbsb looks like there is still a conflict. |
anthonylouisbsb
force-pushed
the
feature/implement-new-true-false-null
branch
from
1061e03
to
03f6ed4
Compare
anthonylouisbsb
force-pushed
the
feature/implement-new-true-false-null
branch
from
03f6ed4
to
a75665f
Compare
|
Benchmark runs are scheduled for baseline = bdb064b and contender = a6c81e6. a6c81e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.