Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-12801: [CI][Packaging][Java] Include all modules in script that generate Arrow jars #10411

Closed
wants to merge 7 commits into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented May 27, 2021

@github-actions
Copy link

@kszucs
Copy link
Member Author

kszucs commented May 27, 2021

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: d4dcd8d

Submitted crossbow builds: ursacomputing/crossbow @ actions-443

Task Status
java-jars Github Actions

@anthonylouisbsb
Copy link
Contributor

The artifacts that were generated by the triggered build are these one https://github.com/ursacomputing/crossbow/releases/tag/actions-443-github-java-jars, right?

The gandiva, dataset and orc components are with the shared libraries for both systems(Linux and MacOS). It looks fine!

@kszucs
Copy link
Member Author

kszucs commented May 27, 2021

The artifacts that were generated by the triggered build are these one https://github.com/ursacomputing/crossbow/releases/tag/actions-443-github-java-jars, right?

Right!

The gandiva, dataset and orc components are with the shared libraries for both systems(Linux and MacOS). It looks fine!

Thanks for verifying!

@kou
Copy link
Member

kou commented May 27, 2021

@kszucs We have missing files to release: https://issues.apache.org/jira/browse/ARROW-12801?focusedCommentId=17352249&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17352249

Do you want to work on including the missing files in this pull request? Or do you want you or @anthonylouisbsb to work on it in a follow-up pull request?

@kszucs
Copy link
Member Author

kszucs commented May 31, 2021

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: c40f74f

Submitted crossbow builds: ursacomputing/crossbow @ actions-444

Task Status
java-jars Github Actions

@kszucs
Copy link
Member Author

kszucs commented Jun 7, 2021

@github-actions crossbow submit java-jars

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

Revision: 4234430

Submitted crossbow builds: ursacomputing/crossbow @ actions-478

Task Status
java-jars Github Actions

@kszucs
Copy link
Member Author

kszucs commented Jun 7, 2021

@github-actions crossbow submit java-jars

1 similar comment
@kszucs
Copy link
Member Author

kszucs commented Jun 8, 2021

@github-actions crossbow submit java-jars

@kszucs
Copy link
Member Author

kszucs commented Jun 8, 2021

@github-actions crossbow submit java-jars

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Revision: 9954900

Submitted crossbow builds: ursacomputing/crossbow @ actions-488

Task Status
java-jars Github Actions

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Revision: 9954900

Submitted crossbow builds: ursacomputing/crossbow @ actions-489

Task Status
java-jars Github Actions

@projjal
Copy link
Contributor

projjal commented Jun 10, 2021

@kszucs Thanks for fixing this. Is there anything left to be done in this patch?

@kszucs
Copy link
Member Author

kszucs commented Jun 10, 2021

We could and probably should list the expected artifacts for the crossbow task so we see if anything is missing during the release process.

@kszucs
Copy link
Member Author

kszucs commented Jun 10, 2021

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: ccf7e36

Submitted crossbow builds: ursacomputing/crossbow @ actions-496

Task Status
java-jars Github Actions

@kszucs
Copy link
Member Author

kszucs commented Jun 10, 2021

@kou I'm copying all files with either .pom or .jar extensions, though we don't have all the packages you listed in your jira comment, see the uploaded packages.

Could we merge this one and address the remaining packages in a follow-up? I assume we'll need to tweak the mvn build command a bit.

@kou
Copy link
Member

kou commented Jun 10, 2021

Sure. Let's do that!

@kszucs
Copy link
Member Author

kszucs commented Jun 11, 2021

Created a follow-up task: ARROW-13051

Copy link
Member Author

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants