ARROW-12984: [C++][Compute] Passing options parameter of Count/Index aggregation by reference #10459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
Crystrix
changed the title
|
Thanks @Crystrix ! |
|
@cyb70289 Sure, |
Crystrix
changed the title
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
…aggregation by reference The options parameter of `Count` function is passed by value, it's better to be passed by reference like other aggregation functions. Closes apache#10459 from Crystrix/arrow-12984 Authored-by: crystrix <chenxi.li@live.com> Signed-off-by: Yibo Cai <yibo.cai@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options parameter of
Countfunction is passed by value, it's better to be passed by reference like other aggregation functions.