Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-13001: [Go][Parquet] fix build failure on s390x #10475

Closed
wants to merge 2 commits into from

Conversation

zeroshade
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

@zeroshade
Copy link
Member Author

@bkietz @emkornfield For attention

@cyb70289
Copy link
Contributor

cyb70289 commented Jun 8, 2021

Also add "xxx_arm64.go"?

@zeroshade
Copy link
Member Author

@cyb70289 do we actually already have an arm build?

@cyb70289
Copy link
Contributor

cyb70289 commented Jun 9, 2021

@cyb70289 do we actually already have an arm build?

We have Arm64 CI for C++, but not for golang.
Please ignore this requirement. I will try adding golang Arm64 CI job first.

@zeroshade
Copy link
Member Author

@cyb70289 Once there is an arm64 golang job, i'm happy to take a look at trying to help fix any failures in it.

Though I have no idea where I'd test it. I got lucky with this one and spun up an s390x VM via IBM Community Cloud so I was able to printline debug to track this down.

Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
An arm/go CI job sounds worthwhile, please file a follow up JIRA.

@bkietz bkietz closed this in bd28d52 Jun 9, 2021
@cyb70289
Copy link
Contributor

#10515 adds Arm go CI job.

michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
Closes apache#10475 from zeroshade/arrow-13001

Authored-by: Matthew Topol <mtopol@factset.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
@zeroshade zeroshade deleted the arrow-13001 branch September 12, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants