ARROW-13104: [C++] Fix unsafe cast in ByteStreamSplit implementation #10596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
force-pushed
the
ARROW-13104-unsafe-cast
branch
from
fb5b5fb
to
ea793ac
Compare
pitrou
commented
Jun 29, 2021
| } | ||
|
|
||
| template <> | ||
| void ByteStreamSplitEncoder<FloatType>::PutArrowArray(const ::arrow::Array& values) { | ||
| DirectPutImpl<::arrow::FloatArray>(values, | ||
| reinterpret_cast<::arrow::BufferBuilder*>(&values_)); |
There was a problem hiding this comment.
This was the offending cast (and below as well).
cyb70289
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
+1.
Tested that inserting a dummy data member (before below line) or a dummy virtual function to TypedBufferBuillder crashes current code.
https://github.com/apache/arrow/blob/master/cpp/src/arrow/buffer_builder.h#L302
|
Thanks for the review @cyb70289 ! I will merge now (AppVeyor failure is unrelated). |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Jun 30, 2021
Closes apache#10596 from pitrou/ARROW-13104-unsafe-cast Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.